[Thunar] Gtk3 porting - preparation step

Uwe mm at edor.eu
Fri Apr 21 12:14:44 CEST 2017 

Hi devs,

I'm quite confused, why the mouseover on the XFCE desktop differs from
the mouseover in thunar. On the desktop there is a nice preview, in
thunar not. Anybody knows a place where to discuss such things?


> Hi André.
> 
> > I'm just not sure about the use of g_object_get/g_object_set  
> (shouldn't Thunar classes provide accessors?)
> 
> If this is the way, this can be done too.
> 
> 
> > TODOs at thunar-standard-view.c:3037  
> 
> I took those TODOs from a previous work of Nick Schermer
> (https://git.x fce.org/users/nick/thunar/log/?h=gtk3)
> 
> But when I checked it up again more closely, first I discovered a new
> feature that you can start dragging files also by using your secondary
> mouse button (left / right depends on your settings). This was
> inactive after applying my patch.
> 
> I made corrections, removed setting up suggested action at all because
> it behaves the same way anyway -> default action is GDK_ACTION_ASK.
> And removed 'context' variable was local anyway.
> 
> There is also (and was) a little bug there that you can't change the
> action by pressing CTRL or CTRL+SHIFT to copy or link the file. But
> this should be solved in another bugfix patch.
> 
> I'm attaching a diff to previous patch, full corrected patch is at
> github.
> https://github.com/vc-01/thunar
> 
> 
> > TODO at thunar-location-buttons.c:626  
> 
> I just removed it.
> 
> 
> 
> Cheers
> 
> Vladimir
> 
> 
> On St, 2017-03-22 at 23:34 -0300, André Miranda wrote:
> > Hello again,
> > I've just reviewed your patch, compiled Thunar and everything seems
> > to be working as expected.
> > I'm just not sure about the use of g_object_get/g_object_set
> > (shouldn't Thunar classes provide accessors?) and the introduced
> > TODOs at thunar-standard-view.c:3037 and thunar-location-
> > buttons.c:626. Besides that the modifications are pretty
> > straightforward, thanks for your contribution.
> > Anyone (Harald, Simon, Andrzej...) could also review the patch and
> > eventually merge?
> > 
> > Cheers,
> > André Miranda
> > 
> > On 03/21/2017 08:18 AM, Vladimír Chren wrote:
> >   
> > > Hi
> > > 
> > > On Po, 2017-03-20 at 21:54 -0300, André Miranda wrote:  
> > > > Hi Vladimír,
> > > > Sorry for the delay.  
> > > No problem.
> > >   
> > > > I wasn't able to apply the patches against current master
> > > > (4feb1d4),
> > > > if possible, upload a GitHub fork with your commits.  
> > > You've probably tried to apply all the patches at once, but only
> > > "cumulative" one is needed. I split this one patch for easy review
> > > purposes to smaller ones. Reading it together would be too
> > > tiresome,
> > > cause is too long and repetitive, but as separated and smaller
> > > changes,
> > > it can take up to 10-15 minutes to review. I should have send them
> > > as
> > > diffs instead. (you can apply cumulative OR all other patch files)
> > > 
> > > I made one addition to previous though, to make sure there are no
> > > futher changes which can brake what is now prepared, I added
> > > CFLAGS="-
> > > DGSEAL_ENABLE $CFLAGS" to configure.ac.in. This can be removed
> > > after
> > > porting is finished.
> > > 
> > > I also uploaded it to github
> > > https://github.com/vc-01/thunar
> > > 
> > > 
> > > 
> > > 
> > > Best regards
> > > 
> > > Vladimir
> > > 
> > >   
> > > > Cheers,
> > > > André Miranda
> > > > 
> > > > On 03/10/2017 05:31 AM, Vladimír Chren wrote:
> > > >   
> > > > > Hello.
> > > > > 
> > > > > I'm sending patches as attachments - separated as mentioned
> > > > > before
> > > > > for
> > > > > easy reviewing, also including cumulative one.
> > > > > 
> > > > > This work (surely not entertaining) solves this one thing
> > > > >  $ make CFLAGS+="-DGSEAL_ENABLE"
> > > > > 
> > > > > This is all current and can be a base for further gtk3
> > > > > porting.
> > > > > 
> > > > > 
> > > > > Greets
> > > > > 
> > > > > --
> > > > > vlado
> > > > > 
> > > > > 
> > > > > On Ut, 2017-03-07 at 22:53 -0300, André Miranda wrote:  
> > > > > > Hi Vladmir,
> > > > > > Every help in the porting effort is more than welcome!
> > > > > > Currently there is unmaintained work[1][2], you can setup a
> > > > > > personal
> > > > > > repository on GitHub and use them as a start point.
> > > > > > Many components and panel plugins have been ported, they are
> > > > > > also
> > > > > > good references.
> > > > > > However I suggest you talk with devs on #xfce-dev so they
> > > > > > can give
> > > > > > you better hints than me.
> > > > > > 
> > > > > > 1 - https://wiki.xfce.org/releng/4.14/roadmap/thunar
> > > > > > 2 - https://github.com/rgcjonas/thunar-gtk3
> > > > > > 
> > > > > > Cheers,
> > > > > > André Miranda
> > > > > > 
> > > > > > On Mon, Mar 6, 2017 at 4:54 AM, Vladimír Chren
> > > > > > <vlado.chren at i nmai
> > > > > > l.sk  
> > > > > > > wrote:
> > > > > > > Hello All.
> > > > > > > 
> > > > > > > I don't know details about Thunar gtk3 porting status but
> > > > > > > it
> > > > > > > looks
> > > > > > > that
> > > > > > > there is no big progress.
> > > > > > > 
> > > > > > > Would you be interested in patches solving one preparation
> > > > > > > step
> > > > > > > of
> > > > > > > porting Thunar to gtk3 according to manual
> > > > > > >  https://developer.gnome.org/gtk3/stable/gtk-migrating-2-to
> > > > > > > -3.h
> > > > > > > tml#
> > > > > > > id-1
> > > > > > > .6.3.3.5
> > > > > > > 
> > > > > > > Chapter "Use accessor functions instead of direct access"
> > > > > > > 
> > > > > > > Patches would look mostly like this
> > > > > > >  -  GTK_BIN (standard_view)->child
> > > > > > >  +  gtk_bin_get_child (GTK_BIN (standard_view))
> > > > > > > 
> > > > > > > and like this
> > > > > > >  - renderer->is_expanded
> > > > > > >  + g_object_get (renderer, "is-expanded", &is_expanded,
> > > > > > > NULL);
> > > > > > > 
> > > > > > > I'll separate each type of change to different patch.
> > > > > > > 
> > > > > > > This could be then applied against master (i think)
> > > > > > > because it's
> > > > > > > still
> > > > > > > gtk2 (2.24.0) and nothing changes functionally. I'll reuse
> > > > > > > what
> > > > > > > was
> > > > > > > already done and update it to current master.
> > > > > > > 
> > > > > > > Patches would be longer but simple to review.
> > > > > > > 
> > > > > > > I'm asking first if it's necessary or useful to do it.
> > > > > > > 
> > > > > > > 
> > > > > > > Thank you
> > > > > > > 
> > > > > > > --
> > > > > > > vlado
> > > > > > > 
> > > > > > > 
> > > > > > > _______________________________________________
> > > > > > > Xfce4-dev mailing list
> > > > > > > Xfce4-dev at xfce.org
> > > > > > > https://mail.xfce.org/mailman/listinfo/xfce4-dev  
> > > > > > _______________________________________________
> > > > > > Xfce4-dev mailing list
> > > > > > Xfce4-dev at xfce.org
> > > > > > https://mail.xfce.org/mailman/listinfo/xfce4-dev
> > > > > > 
> > > > > > 
> > > > > > _______________________________________________
> > > > > > Xfce4-dev mailing list
> > > > > > Xfce4-dev at xfce.org
> > > > > > https://mail.xfce.org/mailman/listinfo/xfce4-dev  
> > > >  
> > > > _______________________________________________
> > > > Xfce4-dev mailing list
> > > > Xfce4-dev at xfce.org
> > > > https://mail.xfce.org/mailman/listinfo/xfce4-dev
> > > > 
> > > > 
> > > > _______________________________________________
> > > > Xfce4-dev mailing list
> > > > Xfce4-dev at xfce.org
> > > > https://mail.xfce.org/mailman/listinfo/xfce4-dev  
> >  
> > _______________________________________________
> > Xfce4-dev mailing list
> > Xfce4-dev at xfce.org
> > https://mail.xfce.org/mailman/listinfo/xfce4-dev

More information about the Xfce4-dev mailing list