Xfce4-Dict GTK3 Port

[André Miranda]

The only drawback I see so far are the menu icons shifted a bit, since 
GtkImageMenuItem is deprecated and the "new way"[1] causes this glitch.

Yes, I'd gladly accept to maintain xfce4-dict.

1 - 
https://developer.gnome.org/gtk3/stable/GtkImageMenuItem.html#GtkImageMenuItem.description

Cheers,
Andre Miranda

On 10/26/2016 05:35 PM, Enrico Tröger wrote:
> I'd be happy if it get merged.
> So far it seems fine and I think once it has been merged to the master
> branch, it will be tested and used by more people.
>
> Furthermore, don't feel forced to ask for permission.
> I don't want to maintain xfc4-dict any longer and I'd be happy if Andre
> or you would like to do it.
>
> Regards,
> Enrico
>
>
> On 26/10/16 21:43, Landry Breuil wrote:
>> Great work, havent looked yet, but linked it on
>> https://wiki.xfce.org/releng/4.14/roadmap#applications
>>
>> Enrico, what do you think about merging it to the master branch ? I
>> can take care of that and grant andre commit rights if you want..
>>
>> Landry
>>
>> On Sun, Oct 23, 2016 at 6:03 PM, André Miranda <andreldm1989 at gmail.com> wrote:
>>> Thanks Enrico for your feedback, this issue has been fixed.
>>>
>>> Cheers,
>>> Andre Miranda
>>>
>>> On 10/23/2016 08:21 AM, Enrico Tröger wrote:
>>>
>>> Hi André,
>>>
>>> The xfce4-dict port to GTK3 is complete, please take a look and report
>>> any regression you may find.
>>>
>>> woohoo.
>>> Great job!
>>>
>>> At a first glance, it looks fine and seems to work as before.
>>> I tested the panel plugin (in a GTK2 built panel) as well as the new IPC
>>> part.
>>>
>>> I encountered only one minor issue:
>>> if you have the panel plugin active, search for some term, then search
>>> via the command line (e.g. 'xfce4-dict hello'), then the main window
>>> pops up and shows the results for "hello" but the search field in the
>>> main window still has the old value. In other words, when a search is
>>> triggered via IPC, the search term field is not updated (this was the
>>> case in the GTK2 version).
>>>
>>>
>>> Apart from that, it looks great.
>>>
>>> Regards,
>>> Enrico
>
>
> _______________________________________________
> Xfce4-dev mailing list
> Xfce4-dev at xfce.org
> https://mail.xfce.org/mailman/listinfo/xfce4-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.xfce.org/pipermail/xfce4-dev/attachments/20161026/48e132b2/attachment.html>