xfce4-panel: why the change in d&d icon?

[Olivier Brunel]

Hi,

I've recently updated to xfce4-panel 4.12.1, released just a few days
ago, and noticed a changed in the icon used when performing drag&drop
with the buttons.

That is, using no sort order (to allow d&d) and showing button labels.
Instead of the usual image of the button itself (so icon & label), only
the icon of the application is now being used.

This is due to commit 8dc83f50[1]. I'm not sure what the motivations
were behind this - the commit doesn't say, and adds a FIXME referring to
repaint error and bug 11283, but that bug[2] doesn't talk about
this, or even xfce4-panel for that matter.

However, I dislike this change, notably because I often have many
terminal emulators open, and now when doing a d&d I always get the same
icon, instead of having the label as well, which helps identifying which
window button I'm actually dragging (it's also why I show labels in
the first place).

Any chance to see this reverted? Or maybe only when labels are
used/shown?

Thanks,


[1]
https://git.xfce.org/xfce/xfce4-panel/patch/?id=8dc83f507d7340fa46c5b8927e5b320c5595fb7d

[2] https://bugzilla.xfce.org/show_bug.cgi?id=11283