<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
The only drawback I see so far are the menu icons shifted a bit,
since GtkImageMenuItem is deprecated and the "new way"[1] causes
this glitch.<br>
<br>
Yes, I'd gladly accept to maintain xfce4-dict.<br>
<br>
1 -
<a class="moz-txt-link-freetext" href="https://developer.gnome.org/gtk3/stable/GtkImageMenuItem.html#GtkImageMenuItem.description">https://developer.gnome.org/gtk3/stable/GtkImageMenuItem.html#GtkImageMenuItem.description</a><br>
<br>
Cheers,<br>
Andre Miranda<br>
<br>
<div class="moz-cite-prefix">On 10/26/2016 05:35 PM, Enrico Tröger
wrote:<br>
</div>
<blockquote cite="mid:61d909f2-173a-dc9b-b071-6309f66d1fc6@xfce.org"
type="cite">
<pre wrap="">I'd be happy if it get merged.
So far it seems fine and I think once it has been merged to the master
branch, it will be tested and used by more people.
Furthermore, don't feel forced to ask for permission.
I don't want to maintain xfc4-dict any longer and I'd be happy if Andre
or you would like to do it.
Regards,
Enrico
On 26/10/16 21:43, Landry Breuil wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Great work, havent looked yet, but linked it on
<a class="moz-txt-link-freetext" href="https://wiki.xfce.org/releng/4.14/roadmap#applications">https://wiki.xfce.org/releng/4.14/roadmap#applications</a>
Enrico, what do you think about merging it to the master branch ? I
can take care of that and grant andre commit rights if you want..
Landry
On Sun, Oct 23, 2016 at 6:03 PM, André Miranda <a class="moz-txt-link-rfc2396E" href="mailto:andreldm1989@gmail.com"><andreldm1989@gmail.com></a> wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Thanks Enrico for your feedback, this issue has been fixed.
Cheers,
Andre Miranda
On 10/23/2016 08:21 AM, Enrico Tröger wrote:
Hi André,
The xfce4-dict port to GTK3 is complete, please take a look and report
any regression you may find.
woohoo.
Great job!
At a first glance, it looks fine and seems to work as before.
I tested the panel plugin (in a GTK2 built panel) as well as the new IPC
part.
I encountered only one minor issue:
if you have the panel plugin active, search for some term, then search
via the command line (e.g. 'xfce4-dict hello'), then the main window
pops up and shows the results for "hello" but the search field in the
main window still has the old value. In other words, when a search is
triggered via IPC, the search term field is not updated (this was the
case in the GTK2 version).
Apart from that, it looks great.
Regards,
Enrico
</pre>
</blockquote>
</blockquote>
<pre wrap="">
</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
Xfce4-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Xfce4-dev@xfce.org">Xfce4-dev@xfce.org</a>
<a class="moz-txt-link-freetext" href="https://mail.xfce.org/mailman/listinfo/xfce4-dev">https://mail.xfce.org/mailman/listinfo/xfce4-dev</a></pre>
</blockquote>
<br>
</body>
</html>