[4.14 Roadmap] Icon name cleanup

[Peter de Ridder]

On Sun, Mar 1, 2015 at 4:38 AM, Steve Dodier-Lazaro <sidnioulz at gmail.com> wrote:
> Hello buddies,
>
> Since we're so fuckin awesome, we're already starting 4.14 development.
> Simon proposed an icon name cleanup throughout the entire project.
>
> Here's a possible way to do it for 2 or 3 projects, to experiment:
> 1. Create BZ report for your project
> 2. Run the icon-use finding script at
> http://sidi.mupuf.org/files/xfce-icons.sh
> 3. Decide which icon names you want to replace by which
> 4. Communicate a list with the project, so we can build up a Xfce icon
> glossary
> 5. Manually commit your changes (to avoid changing non-icon stuff :-( )
>
> Sadly we can't automate everything. Most greps on calls to icon-related
> functions would return lines that don't contain an icon name (because of
> variables/constants and/or line cutting), and we'd have false negatives.
> Grepping *all* the known icon names (3.4k of them...) and STOCK names (taken
> all 105 from GTK+ 2 latestl) ensures we don't miss an icon, but of course we
> get the occasional mismatch with other strings (e.g. "display" or "add").
>

One thing to verify is that the pot file didn't change (translatable
strings only).
Before replacing run 'make -C po update-po' and copy the po/*.pot file.
After replacing do the same and compare the two pot files.
If there are changes the pot file will give you the line numbers.

> I can run a few mini-apps like Screenshooter for testing, though quite
> obviously the bulk of the work will be Thunar :-)
>
> Cheers,
> --
> Steve Dodier-Lazaro
> PhD Student
> University College London
> Free Software Developer
> OpenPGP : 1B6B1670
>

Regards,
Peter