GtkImageMenuItem replacement

[flo.xfce at gmx-topmail.de]

I never intended this to become a discussion about "when", I only
wanted to know "how".
> Manually packing labels is the *upstream recommend way* of doing
> things
This is great to know. I only found statements like "you could to
this, or that, ..."
On the priority list, menu replacement is pretty much at the end, I
understand that. But if one developer finds the time to port one app
there are no consequences for the others, since, as you already
pointed out, they still work. I'd like to experiment with it so that
at a later point, the knowledge and maybe even the code is there when
the ImageMenuItem is finally removed.

Regards
Florian

On 06/07/2015 10:58 AM, Matthew Brush wrote:
> On 2015-06-07 01:33 AM, Simon Steinbeiß wrote:
>> On Sat, 06 Jun 2015 09:26:54 -0700 Matthew Brush
>> <mbrush at codebrainz.ca> wrote: [snip]
>>> Maybe it would be better to copy/fork the whole source code of 
>>> GtkImageMenuItem into libxfce4ui and just rename the class?
>> 
>> IMO there is no good reason to do that, since GtkImageMenuItems
>> still work fine with Gtk3. (And with wrapping it in 
>> G_GNUC_BEGIN_IGNORE_DEPRECATIONS you also don't get any
>> compile-time warnings anymore.) So for now it just creates work
>> for everyone, cause you have to rename your GtkImageMenuItems to
>> XfceImageMenuItems (or whatever it would be called). We could
>> revisit that though when Xfce gets ported to Gtk4 ;)
>> 
> 
> Yeah it was more meant as like; if people can't live with just
> leaving functioning code alone, at least make it all use the same
> code instead of each app rolling its own custom menu item packing
> with icons which may run afoul of existing "global menu" and
> similar stuff people might like to use with Xfce.
> 
> Cheers, Matthew Brush