mbrush at codebrainz.ca
Sun Jun 7 10:58:28 CEST 2015
On 2015-06-07 01:33 AM, Simon Steinbeiß wrote:
> On Sat, 06 Jun 2015 09:26:54 -0700
> Matthew Brush <mbrush at codebrainz.ca> wrote:
>> Maybe it would be better to copy/fork the whole source code of
>> GtkImageMenuItem into libxfce4ui and just rename the class?
> IMO there is no good reason to do that, since GtkImageMenuItems still work fine with Gtk3. (And with wrapping it in G_GNUC_BEGIN_IGNORE_DEPRECATIONS you also don't get any compile-time warnings anymore.)
> So for now it just creates work for everyone, cause you have to rename your GtkImageMenuItems to XfceImageMenuItems (or whatever it would be called). We could revisit that though when Xfce gets ported to Gtk4 ;)
Yeah it was more meant as like; if people can't live with just leaving
functioning code alone, at least make it all use the same code instead
of each app rolling its own custom menu item packing with icons which
may run afoul of existing "global menu" and similar stuff people might
like to use with Xfce.
More information about the Xfce4-dev