Establishing GTK3 port "rules" (and some q.s)

[ikey]

So presenting the gtk 2.24 image menu item isn't much use here.
But I agree, in essence its really not difficult to provide a
replacement image menu item for the porting process.

If it makes 1:1 porting easier, then fine (most likely YES)
However, the comment about stock items stand, they're not to
be used at all.

So what's needed is an xfce image menu item replacement, which
*correctly* integrates.. and uses GtkImage internally, and does
not allow stock usage.

Either way.. this does not need to degrade into a fight about desktops.
Might I also add LXDE is Qt, Unity is Qt with its own GUI toolkit, and
MATE is in-between-lands as well as specifically existing as a fork
of GNOME2, thus none relate to the context of porting XFCE to GTK3
at all.

Simple simple question: Do people still need an image menu item?
 From responses it looks like we should provide something for
compatibility for now. Doesn't need to be anymore complicated than
this.


- ikey

On 20/02/15 17:08, Harald Judt wrote:
> Am 20.02.2015 um 17:55 schrieb Guido Berhoerster:
>> * Olivier Fourdan <fourdan at gmail.com> [2015-02-20 16:52]:
>>>> 2) One whacking great deprecation I can't mentally avoid, so will now
>>>> mention.. GtkImageMenuItem. That fella is gone. What do we want to do
>>>> about this? (Alternatives include just dropping images in menu items
>>>> or forking it into libxfce4ui)
>>>
>>> I'd rather dropping images in menu, forking is usually a dead end.
>>
>> What does that have to do with forking? GtkImageMenuItem is just
>> a convenience wrapper around a GtkImage and a GtkLabel, it's not
>> that they dropped it for any technical reason and it's not a lot
>> of code that would require much maintenance either:
>> https://git.gnome.org/browse/gtk+/tree/gtk/gtkimagemenuitem.c?h=gtk-2-24
>> Putting it into libxfce4ui would just make porting more simple
>> and allow us to keep menu icons (which I would hate to see go from
>> applications like Thunar where they are quite helpful in long
>> menus).
>
> I also do like the icons, they help with the looking up items in menus
> and make the menus less boring. I guess it will not be GtkImageMenuItem
> which is complicated, but rather the icons that are going to be
> deprecated and vanish. That doesn't have to happen, though, many
> designers might not simply throw their work away just because one
> desktop environment deprecates them, especially when it will still be
> used in projects (like Mate, LXDE, Unity,... Xfce?). Perhaps people will
> start creating icon sets specifically for Xfce instead of Gnome? Maybe
> that decision to drop them can also be postponed, when it is more clear
> what will happen in the future.
>
> Harald
>