xfce4-xkb-plugin rework
Jannis Pohlmann
jannis at xfce.org
Sat Aug 18 16:30:00 CEST 2012
On Sun, 05 Aug 2012 16:42:39 +0200
Jérôme Guelfucci <jeromeg at xfce.org> wrote:
> Hi,
>
> I reviewed and tested the changes in xfce4-settings, everything looks
> fine to me except the coding style in some patches (xfce4-settings
> uses a space between function name and arguments: my_fuction (foo)
> and not my_function(foo)).
>
> The code is well documented, fixes a great number of currently open
> bug reports so I'm all for merging it.
>
> Nick and Jannis, do you want to have a look?
I trust you on this, Jérôme. Well documented and fixing bugs sounds
good, so yeah, let's merge it.
@Igor: I've granted you commit rights for xfce4-settings, so you can
push the changes to master yourself. Welcome on board!
- Jannis
More information about the Xfce4-dev
mailing list