Libxfce4ui api review, round 2

[Brian J. Tarricone]

On 2009/07/09 10:54, Mike Massonnet wrote:
> How about some widgets that are inside libexo? Or from Thunar like the
> GtkCellRenderers, there is at least a text renderer used within the settings
> manager but the icon one is also interesting which does a spotlight. That's
> all I can see from both projects.
>
> http://svn.xfce.org/svn/xfce/thunar/trunk/thunar/thunar-icon-renderer.h

Why is this useful for more than one or two Xfce core apps?

> http://svn.xfce.org/svn/xfce/thunar/trunk/thunar/thunar-text-renderer.h

Same question?

> http://svn.xfce.org/svn/xfce/libexo/trunk/exo/exo-cell-renderer-ellipsized-
> text.h

Deprecated.  GtkCellRendererText supports all the features of this and more.

> http://svn.xfce.org/svn/xfce/libexo/trunk/exo/exo-cell-renderer-icon.h

Same question?

Let's not be too hasty to add things.  Only add things *after* there is 
a demonstrated need, and *after* the code has already been copy/pasted 
into more than one app.

And why move things from libexo?  Just link to libexo.

	-b