thunar & make distcheck

[Brian J. Tarricone]

Benny, you too: the thunar test app tries to open a display, which
fails for a headless build...

	-b

On Wed, 24 Oct 2007 19:39:25 -0700 Brian J. Tarricone wrote:

> Hey Jannis,
> 
> libxfce4menu is a little unfriendly to make distcheck (which runs make
> check).  Your tests look like they assume you already have the
> proper .menu files installed on your system, and also require an
> x11 display.  For automatic tarball generation, this kinda doesn't
> work.  I think your first test is reasonable, but you should include
> everything needed for the test inside your test suite and not rely on
> the system to provide bits (well, the system of course provides the
> build-time dependencies, but I think that should be all). The second
> test is useful, but shouldn't be invoked by default, or should at
> least quit with a 'pass' if it can't open an X display (can use
> gtk_init_check() for that).
> 
> What do you think?  For now I'll just special-case your module in my
> script to do 'make dist' instead of 'make distcheck'.
> 
> 	-brian
> _______________________________________________
> Xfce4-dev mailing list
> Xfce4-dev at xfce.org
> http://foo-projects.org/mailman/listinfo/xfce4-dev
>