[Xfce4-commits] r26470 - in libxfcegui4/trunk: . libxfcegui4

[Brian J. Tarricone]

Hey Nick,

On Thu, 13 Dec 2007 10:35:30 +0000 (UTC) Nick Schermer wrote:

> Author: nick
> Date: 2007-12-13 10:35:30 +0000 (Thu, 13 Dec 2007)
> New Revision: 26470
> 
> Modified:
>    libxfcegui4/trunk/ChangeLog
>    libxfcegui4/trunk/libxfcegui4/netk-trayicon.h
> Log:
> 	* libxfcegui4/netk-trayicon.h: Deprecated code. Last piece
> 	  was used in xfce-mcs-plugin, but has been replaced by
> 	  GtkStatusIcon.

When you deprecate stuff, please don't #ifndef out the gobject cast
#defines or the struct typedefs.  This will make code using those
classes fail to compile.  The idea of doing the #ifndef is to cause the
compiler to throw warnings, not error out.  To catch these as a 'hard
fail', you'd use the gcc -Werror flag.

Also, you should add G_GNUC_DEPRECATED to the end of function prototypes
in the headers (and maybe you can use that for the typedefs too; not
sure).

	-brian