XFce 22.214.171.124 support for SunStudio under Solaris
Brian J. Tarricone
bjt23 at cornell.edu
Mon May 22 06:08:06 CEST 2006
-----BEGIN PGP SIGNED MESSAGE-----
Auke Kok wrote:
> I doubt these should be merged as such:
> * removing the panel locks will cause breakage. it's probably better to fix
> the XFCE_PANEL_(LOCK|UNLOCK) routines to compile on __sun, and then it will
> also compile properly when people add new _LOCK and _UNLOCK calls.
Not really. The panel locks haven't been used in... over a year maybe?
And they were only there for a little while during the development
cycle, so there shouldn't even be any released version of Xfce that
has/uses them. They should be safe to remove from the xfce4-mixer
plugin entirely. Assuming xfce4-mixer is an external plugin now (which
it should be), they're irrelevant anyway.
> * fixing a void that returns a value seems bogus - void functions don't return
> anything so the original code seems buggy ;^) (and should be fixed instead of
> obfustcated, obviously)
Yeah, that looks like an error in the original code...
> I'm not sure about the module license patch, I'm sure someone else can look at
> the macro's.
I recall that issues with those macros pop up from time to time on
non-gcc compilers, but I'm no expert...
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)
-----END PGP SIGNATURE-----
More information about the Xfce4-dev