[Xfce4-commits] r17207 - libxfcegui4/trunk/libxfcegui4

[Brian J. Tarricone]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Benedikt Meurer wrote:
> Brian Tarricone wrote:
> 
>> static void
>>-xfce_framebox_class_init (XfceFrameboxClass * class)
>>+xfce_framebox_class_init (XfceFrameboxClass * klass)
>> {
>>-    GObjectClass *gobject_class = G_OBJECT_CLASS (class);
>>-    GtkObjectClass *object_class;
>>-    GtkWidgetClass *widget_class;
>>+    typedef void (*ContainerAddFunc)(GtkContainer *, GtkWidget *);
>>+    GtkContainerClass *container_class = (GtkContainerClass *)klass;
>>+    
>>+    container_class->add = (ContainerAddFunc)xfce_framebox_add;
>>+    container_class->remove = xfce_framebox_remove;
>>+}
> 
> 
> This looks pretty strange: add() and remove() will act on the internal
> HBox, while all other GtkContainer methods will work on the frame
> itself. Either XfceFramebox should be deprecated completely or we need
> to override all of GtkContainer methods and forward the calls to the
> internal HBox.

I wouldn't mind deprecating it in favor of a non-class helper/utility
function to create the framebox as we have it now.

Otherwise we can just leave it as-is.  The common use case is just to
add() something to it and be done with it.  I got rid of the remove()
implementation because it was causing weird problems that I don't have
the patience to try to debug.

But I'm done for the night...  I'm tired of messing with this stuff, and
I haven't even gotten to play with my perl bindings tonight ^_~.

	-b

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)

iD8DBQFDFVW66XyW6VEeAnsRAmGaAJ4ue7qVSk8jPA29sbbyHky85SJhcQCfdUrE
hJtHdeVx0i5pZEOGOwnXEmY=
=bYpw
-----END PGP SIGNATURE-----