Desktop settings bug

[Brian J. Tarricone]

On Tue, 22 Jun 2004, Don Christensen wrote:

> One curious thing I noticed is that the Brightness slider now ranges
> from -128 to 127, where I am pretty sure it used to go from 0 to 100.
> It doesn't appear to have any effect on the image I am using as a
> background, either.

yah.  i originally implemented what was actually a color saturation 
control, but blatantly lied about it in the dialog label.  i have since 
turned it into a real brightness control.  it's actually a brightness 
_adjustment_ control (perhaps "Adjust Brightness" would be a more 
descriptive slider label?).  in essence, it will adjust pixel values +/- 
7 bits from their original value.  zero in this context means "leave my 
image the #*$@ alone!".  i'm not sure why it isn't working for you.

> Also, in the file selection dialog, getting into hidden (dot)
> directories is non-obvious at the very least.  I just now realized
> I can type in the name of the directory (".xfce4", for example) and
> hit TAB, but I think it would be more intuitive to have a "show hidden
> files/directories" toggle.

yah, i've never liked that, but that's GtkFileSelection for you.  not 
much i can do about it without a headache i'm not willing to weather.

on a related note, the gtk 2.4 GtkFileChooser doesn't even _have_ a text 
entry box, and hides dotfiles by default.  you have to ctrl+l to bring 
up a location box that does autocomplete.  i'd love the new file 
selector if it wasn't for this.

> Oh, and I might as well mention while I'm here that I see the
> following messages when I run "xfce-setting-show":
> 
> (xfce-mcs-manager:20218): GLib-GObject-CRITICAL **: file gobject.c: line 1337 (g_object_unref): assertion `G_IS_OBJECT (object)' failed
> (xfce-mcs-manager:20218): GLib-GObject-CRITICAL **: file gobject.c: line 1319 (g_object_ref): assertion `G_IS_OBJECT (object)' failed
> (xfce-mcs-manager:20218): libxfcegui4-CRITICAL **: file xfce_scaled_image.c: line 207 (xfce_scaled_image_scale): assertion `GDK_IS_PIXBUF (image->pb)' failed

i don't think that's me.  i'm not using the XfceScaledImage widget.  oh, 
probably when using xfce-setting-show with no argument?  hmm, i guess 
the main settings panel is probably using it.  i dunno.  /me looks at 
jasper.

> Let me know if I can provide any more detail on this.

i'd like to figure out why your brightness control doesn't do anything. 
though i'm not sure of the best way to debug this, other than sticking a 
bunch of print statements in xfdesktop.  which i may do, if i have some 
time later (doubtful, before the weekend anyway).

> Thanks for the fix,

thanks for the report ^_^.

	-brian


> -Don
> 
> Brian J. Tarricone wrote:
> > ok, as lame as it is to reply to myself....   i did a little digging in 
> > the gtk 2.2 source, and it seems it sets up the OK button in a 
> > GtkFileSelection with a default response of GTK_RESPONSE_OK, where i 
> > look for GTK_RESPONSE_ACCEPT to indicate that the user has OK-ed the 
> > file selection.  blah.  i changed XfceFileChooser so it actually pays 
> > attention to the buttons and response ids passed to the constructor for 
> > gtk 2.2, and wrote a little test app to check, and it appears to work.  
> > update libxfcegui4 and let me know.  (remember to restart 
> > xfce-mcs-manager!)
> > 
> >    -brian
> > 
> > 
> > Brian J. Tarricone wrote:
> > 
> >> unfortunately i've been unable to test, as i can't get 
> >> xfce-mcs-manager to properly link with gtk 2.2 while gtk 2.4 is 
> >> present on my system, and i don't particularly feel like downgrading.  
> >> running in a sort of hybrid lib mode causes xfce-mcs-manager to crash 
> >> on opening a settings dialog; not too useful.
> >>
> >> looking at the code, i'm pretty baffled as to why this could be 
> >> happening.  just a sanity check: make sure you're running the latest 
> >> libxfcegui4, xfce-mcs-manager, and xfdesktop.  if you update 
> >> xfdesktop, remember that you won't see any changes made to the 
> >> settings panel unless you restart xfce-mcs-manager.
> >>
> >> the settings panel just uses gtk_dialog_run() on the file chooser, and 
> >> then calls gtk_file_selection_get_filename() on it after ok is 
> >> clicked.  is the file chooser disappearing after you click ok?  if 
> >> not, that could be an indication that gtk_dialog_run() isn't 
> >> returning.  i'd guess that isn't the case, as gtk_dialog_run() also 
> >> blocks all other input, so i'd imagine you would have mentioned that.  
> >> (note to self: stop using gtk_dialog_run().)
> >>
> >> can anyone else with gtk 2.2 and current xfdesktop cvs reproduce this?
> >>
> >>    -brian
> >>
> >> Don Christensen wrote:
> >>
> >>> On CVS HEAD:
> >>>
> >>> In the Desktop Settings dialog, clicking on the little browser icon
> >>> and selecting a file there does not work.  The selected file is not
> >>> propogated back into the "File" filed in the main dialog.
> >>>
> >>> Also, using "New List", clicking the "+", and selecting a file does
> >>> not propogate the selection back into the list.
> >>>
> >>> The only way to select a list or file for the background image is
> >>> to actually type it into the File field.
> >>>
> >>> I'm running RH Enterprise Linux with the 2.4.21 kernel and gtk+ 2.2.4.
> >>>
> >>> -Don
> 
> 
>