Desktop settings bug

[Don Christensen]

That seems to work.

One curious thing I noticed is that the Brightness slider now ranges
from -128 to 127, where I am pretty sure it used to go from 0 to 100.
It doesn't appear to have any effect on the image I am using as a
background, either.

Also, in the file selection dialog, getting into hidden (dot)
directories is non-obvious at the very least.  I just now realized
I can type in the name of the directory (".xfce4", for example) and
hit TAB, but I think it would be more intuitive to have a "show hidden
files/directories" toggle.

Oh, and I might as well mention while I'm here that I see the
following messages when I run "xfce-setting-show":

(xfce-mcs-manager:20218): GLib-GObject-CRITICAL **: file gobject.c: line 1337 (g_object_unref): assertion `G_IS_OBJECT (object)' failed
(xfce-mcs-manager:20218): GLib-GObject-CRITICAL **: file gobject.c: line 1319 (g_object_ref): assertion `G_IS_OBJECT (object)' failed
(xfce-mcs-manager:20218): libxfcegui4-CRITICAL **: file xfce_scaled_image.c: line 207 (xfce_scaled_image_scale): assertion `GDK_IS_PIXBUF (image->pb)' failed

Let me know if I can provide any more detail on this.

Thanks for the fix,
-Don

Brian J. Tarricone wrote:
> ok, as lame as it is to reply to myself....   i did a little digging in 
> the gtk 2.2 source, and it seems it sets up the OK button in a 
> GtkFileSelection with a default response of GTK_RESPONSE_OK, where i 
> look for GTK_RESPONSE_ACCEPT to indicate that the user has OK-ed the 
> file selection.  blah.  i changed XfceFileChooser so it actually pays 
> attention to the buttons and response ids passed to the constructor for 
> gtk 2.2, and wrote a little test app to check, and it appears to work.  
> update libxfcegui4 and let me know.  (remember to restart 
> xfce-mcs-manager!)
> 
>    -brian
> 
> 
> Brian J. Tarricone wrote:
> 
>> unfortunately i've been unable to test, as i can't get 
>> xfce-mcs-manager to properly link with gtk 2.2 while gtk 2.4 is 
>> present on my system, and i don't particularly feel like downgrading.  
>> running in a sort of hybrid lib mode causes xfce-mcs-manager to crash 
>> on opening a settings dialog; not too useful.
>>
>> looking at the code, i'm pretty baffled as to why this could be 
>> happening.  just a sanity check: make sure you're running the latest 
>> libxfcegui4, xfce-mcs-manager, and xfdesktop.  if you update 
>> xfdesktop, remember that you won't see any changes made to the 
>> settings panel unless you restart xfce-mcs-manager.
>>
>> the settings panel just uses gtk_dialog_run() on the file chooser, and 
>> then calls gtk_file_selection_get_filename() on it after ok is 
>> clicked.  is the file chooser disappearing after you click ok?  if 
>> not, that could be an indication that gtk_dialog_run() isn't 
>> returning.  i'd guess that isn't the case, as gtk_dialog_run() also 
>> blocks all other input, so i'd imagine you would have mentioned that.  
>> (note to self: stop using gtk_dialog_run().)
>>
>> can anyone else with gtk 2.2 and current xfdesktop cvs reproduce this?
>>
>>    -brian
>>
>> Don Christensen wrote:
>>
>>> On CVS HEAD:
>>>
>>> In the Desktop Settings dialog, clicking on the little browser icon
>>> and selecting a file there does not work.  The selected file is not
>>> propogated back into the "File" filed in the main dialog.
>>>
>>> Also, using "New List", clicking the "+", and selecting a file does
>>> not propogate the selection back into the list.
>>>
>>> The only way to select a list or file for the background image is
>>> to actually type it into the File field.
>>>
>>> I'm running RH Enterprise Linux with the 2.4.21 kernel and gtk+ 2.2.4.
>>>
>>> -Don


-- 
Don Christensen       Senior Software Development Engineer
djc at cisco.com         Cisco Systems, Santa Cruz, CA
   "It was a new day yesterday, but it's an old day now."