Desktop settings bug

[Brian J. Tarricone]

ok, as lame as it is to reply to myself....   i did a little digging in 
the gtk 2.2 source, and it seems it sets up the OK button in a 
GtkFileSelection with a default response of GTK_RESPONSE_OK, where i 
look for GTK_RESPONSE_ACCEPT to indicate that the user has OK-ed the 
file selection.  blah.  i changed XfceFileChooser so it actually pays 
attention to the buttons and response ids passed to the constructor for 
gtk 2.2, and wrote a little test app to check, and it appears to work.  
update libxfcegui4 and let me know.  (remember to restart xfce-mcs-manager!)

    -brian


Brian J. Tarricone wrote:

> unfortunately i've been unable to test, as i can't get 
> xfce-mcs-manager to properly link with gtk 2.2 while gtk 2.4 is 
> present on my system, and i don't particularly feel like downgrading.  
> running in a sort of hybrid lib mode causes xfce-mcs-manager to crash 
> on opening a settings dialog; not too useful.
>
> looking at the code, i'm pretty baffled as to why this could be 
> happening.  just a sanity check: make sure you're running the latest 
> libxfcegui4, xfce-mcs-manager, and xfdesktop.  if you update 
> xfdesktop, remember that you won't see any changes made to the 
> settings panel unless you restart xfce-mcs-manager.
>
> the settings panel just uses gtk_dialog_run() on the file chooser, and 
> then calls gtk_file_selection_get_filename() on it after ok is 
> clicked.  is the file chooser disappearing after you click ok?  if 
> not, that could be an indication that gtk_dialog_run() isn't 
> returning.  i'd guess that isn't the case, as gtk_dialog_run() also 
> blocks all other input, so i'd imagine you would have mentioned that.  
> (note to self: stop using gtk_dialog_run().)
>
> can anyone else with gtk 2.2 and current xfdesktop cvs reproduce this?
>
>    -brian
>
> Don Christensen wrote:
>
>> On CVS HEAD:
>>
>> In the Desktop Settings dialog, clicking on the little browser icon
>> and selecting a file there does not work.  The selected file is not
>> propogated back into the "File" filed in the main dialog.
>>
>> Also, using "New List", clicking the "+", and selecting a file does
>> not propogate the selection back into the list.
>>
>> The only way to select a list or file for the background image is
>> to actually type it into the File field.
>>
>> I'm running RH Enterprise Linux with the 2.4.21 kernel and gtk+ 2.2.4.
>>
>> -Don
>>
> _______________________________________________
> Xfce4-dev mailing list
> Xfce4-dev at xfce.org
> http://lunar-linux.org/mailman/listinfo/xfce4-dev
>
>