xffm settings and mcs

[edscott wilson garcia]

Hey Olivier,

El vie, 09-05-2003 a las 10:59, Olivier Fourdan escribió:
> Hi Edscott,
> 
> On Fri, 2003-05-09 at 14:43, edscott wilson garcia wrote:
> > > The env. variable stuff don't work anyway. xffm complains "Invalid
> > > Argument:TERM=<whatever I type>"
> > 
> > Maybe the keypressed handler is sending something screwy now that it's
> > an editable treeview. I don't have internet at the moment so my CVS is
> > not up to date (I'll be pressing the "send" button tommorrow).
> 
> No, it wasn't working before either. And the keypress part is removed
> anyway (it's a bit overhead to transmit the data each time a key is
> pressed)

Yes, you're right (I was just guessing). It's fixed now. And if you
enter TERM with something which is not executable in path, it will be
blissfully ignored (with the warning of course;) BTW, the behaviour
without the keypressed is less confusing (at least to me).

> 
> 
> > Actually I don't think it's the plugin that's broken, but rather my 
> > idea of the plugin. As you have probably noticed, it has changed
> > drastically from time to time, which just shows that I don't have a
> > clear idea of how it should work. The plugin could definitely benefit
> > from everybody's help.
> 
> I guess I can help, I wrote the mcs....

Perfect!

> 
> > I used environment variables because the coding is easier for me. Just a
> > simple "getenv()" where required, instead of adding variables to the 
> > associated structures. Whenever I change libs/types.h to add variables
> > to the  associated structures, "make" will recompile everything, and on
> > a slow machine that's a real pain. Throwing the variable to the
> > environment, and later retrieving it when necessary, means that only one
> > or two modules need to be recompiled. That way I cut down drastically on
> > development time. 
> 
> Here I can't help :) However, this part is not supposed to change so
> often si that should not impact the compile time.

I think I can make the switch without much trouble. Replacing
XFFM_HIDE_FSTAB, XFFM_HIDE_BOOK, XFFM_HIDE_LOCAL, XFFM_HIDE_NETWORK,
XFFM_HIDE_APPS, XFFM_HIDE_FIND, XFFM_HIDE_TRASH,XFFM_APPEND_FILES and
XFFM_HOLD_XTERM with simple checkboxes in the plugin would make the
interface much cleaner. All the values except SMB_USER should also be
saved. XFFM_STATUS_LINE_LENGTH, XFFM_MAX_PREVIEW_SIZE would serve better
as numeric spin buttons. That would leave the editable treeview with
XTERM, XFFM_HOME, SMB_USER and SMB_CODESET. Do you want me to go ahead
with these modification? (i.e., does it make sense?)

> 
> > The environment variables were not meant to be saved by mcs, but rather
> > inherited by the mcs from its parent process. This is what I thought at
> > the coding time and may or may not have been a good idea. The theme and
> > default icon size were being saved, so if they not anymore then
> > something got broken. 
> 
> I'll double check then.

I vaguely recall I fixed a bug relating to the "views" not being saved.
I very well may have broken something else in the process....

saludos,

Edscott

> 
> Cheers,
> -- 
> Olivier Fourdan <fourdan at xfce.org>
> http://www.xfce.org
> 
> _______________________________________________
> Xfce4-dev mailing list
> Xfce4-dev at xfce.org
> http://moongroup.com/mailman/listinfo/xfce4-dev
>