Xfce-funklor ->xfwm crash
Olivier Fourdan
fourdan at xfce.org
Sun Jul 20 22:58:46 CEST 2003
Ric,
The new xfce engine (2.1.3) that ships with rc2 accepts both "TRUE" and
"true", so it's backward compatible with older xfce themes.
Cheers,
Olivier.
On Sat, 2003-07-19 at 11:52, Ric wrote:
> --- Olivier Fourdan <fourdan at xfce.org> wrote:
> > Ric,
> >
> > Frankly, I see your proposal as a horrible hack :)
> >
> > Really, I won't maintain a black list of GTK themes hardcoded in the
> > setting manager...
>
> huh? who said/asked that? I certainly did not. That would be D! near
> impossible to create or maintain -there must be a thousand GTK+ themes by now.
> All I suggested was that you use a list that you know works: The default
> themes installed + whatever else you think is appropriate... but not use the
> entire gtk+ gallery and whatever the user has in $HOME/.themes/ too ...
>
> whatever...
>
> The problem apparently is that funklor uses " TRUE" instead of " true " in the
> gtk2 gtkrc file. I made changes to funklor's gtkrc by reducing the spacing
> and changing it to read
>
> engine "xfce"
> {
> smooth_edge = true
> }
> }
>
> It was ... " = TRUE " before. That seems to have fixed the crash problem. I
> have not been able to get it to do it anymore.
> While testing that change I clicked on Redmondxp and ir did not work properly
> but since it did not CRASH the system, found an error in the .xsession-errors
> file indicating that it had the same problem(TRUE).
>
> GLib-GObject-CRITICAL **: file gobject.c: line 1337 (g_object_unref):
> assertion `G_IS_OBJECT (object)' failed
> /usr/share/themes/Xfce-Redmondxp/gtk-2.0/gtkrc:43: error: unexpected
> identifier `TRUE', expected keyword
>
> As soon as I made the same changes to it, changed TRUE to true(in two places),
> the error went away.
> I also noticed that xfce-funklor and xfce-Redmondxp are almost the same theme;
> it's prbly a copy error. BTW, " TRUE " is used a lot in gtk gtkrc files but I
> could not find any gtk2 gtkrc files with it. All of them are lower case.
>
> Of course I have no way of knowing if that is _the_ fix or just a hack that
> makes it appear to be okay. It looks like Glib really cares if one uses
> capitals but idunno if it should or not. Personally, I would hope not.
>
> System/X/WM crashes are not a good thing. ... If there is some way to prevent
> that from happening, well, IMHO, it should be done.
>
> There is not a lot that we can do about gtk-engines2 but since
> " Xfce-Redmondxp " came from the old gtk-xfce-engine it can be replaced
> with the newer " xfce-redmondxp " files. The two are different, but not
> that much. And the easy way to fix xfce-funklor is to include it in a new
> gtk-xfce-engine-2 release with the appropriate changes and also replace
> the old files. Or whatever way you think is best. ...
>
>
> > Cheers,
> > Olivier.
> >
> > On Fri, 2003-07-18 at 22:58, Ric wrote:
> > > --- Olivier Fourdan <fourdan at xfce.org> wrote:
> > > > Ric,
> > > >
> > > > No, I disagree. The syntax inside the engine changed, and using old
> > > > themes is causing syntax errors. Now, if that crashes gtk, then the root
> > > > cause of the crash should be fixed IMO...
> > > >
> > > > I did not find anything wrong in my code, so I don't know what causes
> > > > the crash.
> > >
> > > Man I can appreciate that! Maybe there is nothing 'wrong'...
> > > The thing is that you are correct: THE solution is to make it so that gtk
> > > themes won't do that.
> > > But that may not be possible by XFce as, maybe, it is a GTK+ problem. (?)
> > > In the interim though, until a real solution is found, not having themes
> > in
> > > the list that you know are going to cause problems would be a good idea,
> > > ithink. The user is going to think "it works in xyz - it must be XFce v4
> > at
> > > fault". It seems a bit unfair but that is always the way it is.
> > > It begs the question: how many of the themes in the Settings can cause
> > > problems? Does anyone know? If not, then only listing themes from the
> > panel
> > > default install and xfce-gtk-engine might be a really good thing until a
> > > proper fix is found. (presuming of course that you know those themes are
> > AOK).
> > >
> > >
> > > > Cheers,
> > > > Olivier.
> > > >
> > > > On Fri, 2003-07-18 at 22:26, Ric wrote:
> > > > > Olivier:
> > > > >
> > > > > Thanks.
> > > > > However, no end user is going to know that. I didn't know where
> > > > Xfce-funklor
> > > > > originated(until now) . It is in the Settings Mangler/UI list and
> > > > therefore
> > > > > should just work. If there are incompatible themes, they should not
> > be in
> > > > the
> > > > > list that is produced by Settings Manager/User Interface, IMHO.
> > Perhaps a
> > > > > little more control on what gets placed in that list is warranted ?
> > > > >
> > > > >
> > > > > --- Olivier Fourdan <fourdan at xfce.org> wrote:
> > > > > > Ric,
> > > > > >
> > > > > > Xfce-funklor is not compatible with latest xfce engine and may crash
> > GTK
> > > > > > apps.
> > > > > >
> > > > > > Just use the xfce themes that ship with the version of
> > gtk-xfce-engine
> > > > > >
> > > > > > Cheers,
> > > > > > Olivier.
> > > > > >
> > > > > > On Fri, 2003-07-18 at 21:40, Ric wrote:
> > > > > > > Hi:
> > > > > > >
> > > > > > > I experienced another problem with Xfce-funklor previously too but
> > it
> > > > > > seemed
> > > > > > > to be random and not always repeatable so no report but it just
> > > > screwed
> > > > > > the
> > > > > > > system again with RC1:
> > > > > > >
> > > > > > > I was clicking on different User Interface selections to find one
> > that
> > > > > > might
> > > > > > > be similar to the Bluex from XFce v3(no luck there) and when I
> > clicked
> > > > on
> > > > > > > xfce-funklor I lost all window decorations and mouse buttons. I
> > had
> > > > > > clicked
> > > > > > > on/changed about 10 themes before I got to Xfce-funklor. Also, I
> > > > noticed
> > > > > > that
> > > > > > > part of gkrellm was showing on that workspace which it should not
> > have
> > > > > > been.
> > > > > > > All the other open X processes might have been there too but were
> > > > obscured
> > > > > > by
> > > > > > > galeon windows.
> > > > > > > The only way out of that situation was the three fingered kill of
> > X.
> > > > > > >
> > > > > > > Previously, in Beta 2:
> > > > > > > -clicked on theme XFce-funklor and the Settings Manager died and
> > > > would
> > > > > > not
> > > > > > > restart by clicking on panel icon. I checked the running processes
> > and
> > > > > > (xf)
> > > > > > > panel, desktop, wm, taskbar (and xscreensaver) were all apparently
> > > > running
> > > > > > > normally. That was semi-repeatable.
> > > > > > >
> > > > > > > I do not know if it would have worked but it would have been nice
> > if I
> > > > > > could
> > > > > > > have just restarted xfwm4. Is there a way to set & do that from
> > the
> > > > > > > keyboard?
> > > > > > >
> > > > > > >
> > > > > > > =====
> > > > > > > Have A Great Day!
> > > > > > >
> > > > > > > Ric
> > > > > > > ***
> > > > > > > Thought for today:
> > > > > > > Do not take yourself too seriously. Nobody else does. ;)
> > > > > > >
> > > > > > > __________________________________
> > > > > > > Do you Yahoo!?
> > > > > > > SBC Yahoo! DSL - Now only $29.95 per month!
> > > > > > > http://sbc.yahoo.com
> > > > > > > _______________________________________________
> > > > > > > Xfce4-dev mailing list
> > > > > > > Xfce4-dev at xfce.org
> > > > > > > http://moongroup.com/mailman/listinfo/xfce4-dev
> > > > > > --
> > > > > > Olivier Fourdan - fourdan at xfce.org
> > > > > >
> > > > > > Interoperability is the keyword, uniformity is a dead end.
> > > > > > http://www.xfce.org
> > > > > >
> > > > > >
> > > > > >
> > > > > > _______________________________________________
> > > > > > Xfce4-dev mailing list
> > > > > > Xfce4-dev at xfce.org
> > > > > > http://moongroup.com/mailman/listinfo/xfce4-dev
> > > > >
> > > > >
> > > > > =====
> > > > > Have A Great Day!
> > > > >
> > > > > Ric
> > > > > ***
> > > > > Thought for today:
> > > > > Do not take yourself too seriously. Nobody else does. ;)
> > > > >
> > > > > __________________________________
> > > > > Do you Yahoo!?
> > > > > SBC Yahoo! DSL - Now only $29.95 per month!
> > > > > http://sbc.yahoo.com
> > > > > _______________________________________________
> > > > > Xfce4-dev mailing list
> > > > > Xfce4-dev at xfce.org
> > > > > http://moongroup.com/mailman/listinfo/xfce4-dev
> > > > --
> > > > Olivier Fourdan - fourdan at xfce.org
> > > >
> > > > Interoperability is the keyword, uniformity is a dead end.
> > > > http://www.xfce.org
> > > >
> > > >
> > > >
> > > > _______________________________________________
> > > > Xfce4-dev mailing list
> > > > Xfce4-dev at xfce.org
> > > > http://moongroup.com/mailman/listinfo/xfce4-dev
> > >
> > >
> > > =====
> > > Have A Great Day!
> > >
> > > Ric
> > > ***
> > > Thought for today:
> > > Do not take yourself too seriously. Nobody else does. ;)
> > >
> > > __________________________________
> > > Do you Yahoo!?
> > > SBC Yahoo! DSL - Now only $29.95 per month!
> > > http://sbc.yahoo.com
> > > _______________________________________________
> > > Xfce4-dev mailing list
> > > Xfce4-dev at xfce.org
> > > http://moongroup.com/mailman/listinfo/xfce4-dev
> > --
> > Olivier Fourdan - fourdan at xfce.org
> >
> > Interoperability is the keyword, uniformity is a dead end.
> > http://www.xfce.org
> >
> >
> >
> > _______________________________________________
> > Xfce4-dev mailing list
> > Xfce4-dev at xfce.org
> > http://moongroup.com/mailman/listinfo/xfce4-dev
>
>
> =====
> Have A Great Day!
>
> Ric
> ***
> Thought for today:
> Do not take yourself too seriously. Nobody else does. ;)
>
> __________________________________
> Do you Yahoo!?
> SBC Yahoo! DSL - Now only $29.95 per month!
> http://sbc.yahoo.com
> _______________________________________________
> Xfce4-dev mailing list
> Xfce4-dev at xfce.org
> http://moongroup.com/mailman/listinfo/xfce4-dev
--
Olivier Fourdan - fourdan at xfce.org
Interoperability is the keyword, uniformity is a dead end.
http://www.xfce.org
More information about the Xfce4-dev
mailing list