[Thunar-dev] Werror

[Jani Monoses]

Benedikt Meurer wrote:
> Jani Monoses wrote:
>> Hi
> 
> Hey Jani,
> 
>> is building with -Werror needed also when ELF visibility is enabled not 
>> just debug mode?
> 
ah, I got confused by the temporary use of -Werror in CFLAGS while 
running the test program for visibility.

> -Werror has nothing to do with the ELF visiblity stuff. -Werror is added
> for --enable-debug=yes (the default for SVN snapshots) and
> --enable-debug=full, while its disabled for --enable-debug=minimum
> (default for releases) and --enable-debug=no. I think for Ubuntu
> snapshots it should be fine to use --enable-debug=minimum.
>
ok, thanks

>> Also this causes powerpc and amd64 to fail to build, I'll file a bug 
>> later unless it is trivially fixed by tonight :)
>>
>> cc1: warnings being treated as errors
>> thunar-vfs-job.c: In function 'thunar_vfs_job_source_dispatch':
>> thunar-vfs-job.c:280: warning: passing argument 4 of 
>> 'g_signal_emit_valist' discards qualifiers from pointer target type
> 
> Hm, we'd need to cast away volatile there. On the other hand, I could
> also just use g_pointer_get(), which presents a memory barrier. Hmhm.
> File a bug, I'll look into this later.

http://bugzilla.xfce.org/show_bug.cgi?id=1756

Jani.