[Thunar-dev] Werror

[Benedikt Meurer]

Jani Monoses wrote:
> Hi

Hey Jani,

> is building with -Werror needed also when ELF visibility is enabled not 
> just debug mode?

-Werror has nothing to do with the ELF visiblity stuff. -Werror is added
for --enable-debug=yes (the default for SVN snapshots) and
--enable-debug=full, while its disabled for --enable-debug=minimum
(default for releases) and --enable-debug=no. I think for Ubuntu
snapshots it should be fine to use --enable-debug=minimum.

> Also this causes powerpc and amd64 to fail to build, I'll file a bug 
> later unless it is trivially fixed by tonight :)
> 
> cc1: warnings being treated as errors
> thunar-vfs-job.c: In function 'thunar_vfs_job_source_dispatch':
> thunar-vfs-job.c:280: warning: passing argument 4 of 
> 'g_signal_emit_valist' discards qualifiers from pointer target type

Hm, we'd need to cast away volatile there. On the other hand, I could
also just use g_pointer_get(), which presents a memory barrier. Hmhm.
File a bug, I'll look into this later.

Benedikt