About xfce-screensaver.c

[Simon Steinbeiss]

> Well, at least slock (which is hard coded in current xflock4) and i3lock
do not handle DPMS by themselves. Anyway, alternatively there could be a
separate wrapper script for the job and user could set LockCommand to run
it, so it would be independent of xflock4. I agree it would be less
confusing that way besides being more modular.

Yup, that would be the "small start" I could imagine.

> It’s only my opinion and I don’t speak for the Xfce team.

Also: what Cyrille said, I couldn't agree more.
It's true that the current situation is hard to completely understand for
someone who doesn't know all the pieces (and you can expect that of pretty
much any Xfce developer who is around now) and a diagram could help.
Also tests (even if in the form of manually triggered shell scripts or
manual test instructions) would help.

Cheers
Simon


On Tue, May 4, 2021 at 12:22 AM Cyrille Pontvieux <cyrille at enialis.net>
wrote:

> Hello,
>
> First, I do not belong to the Xfce team.
>
> If you, Jarno, plan to make deep modifications in this area (locking,
> sleeping, DPMS, …), maybe a diagram of current situation and proposed
> situation could help (to agree or not, to alter the design, …)
>
> It will also be less scary with some sort of tests (I do not know if
> those components already have some or not). Tests for current situation
> first, then with the proposed evolution.
>
> Xfce dev team is a small team, and I’m not sure there is a person
> responsible for such big changes (in features) across different
> components/scripts.
>
> So, in my opinion, to convince, you should not only communicate (through
> email or such) but also prove (by automatic tests, reproducible builds,
> that kind of things) that your ideas are better than the status quo. As
> the team is small, any change needs to be fully apprehended by the
> maintainer and the result code should be as small and as simple as
> possible, even if not all cases are covered.
>
> This is just my advice after reading the discussion on this subject.
> It’s only my opinion and I don’t speak for the Xfce team.
>
> Cyrille Pontvieux
> _______________________________________________
> Xfce4-dev mailing list
> Xfce4-dev at xfce.org
> https://mail.xfce.org/mailman/listinfo/xfce4-dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.xfce.org/pipermail/xfce4-dev/attachments/20210504/4f892c0a/attachment-0001.html>