zakhams at gmail.com
Wed Aug 16 17:59:59 CEST 2017
I tested your patches. They are very good but I found some issues.
1. libxfce4ui builds both for gtk2 and gtk3. Your custom widget is not
compatible to gtk2 so now libxfce4ui can't be built without --disable-gtk2.
2. libxfce4ui is not builable with --enable-gtk-doc.
There is also a small GUI issue. I found that you can scroll and zoom
the widget. That's great, but I can overscroll the widget too much.
I think that image should never be scrolled over its corners. Is it
possible to fix? Of course it's not so important as the issues described
above but it would be very nice to see this fixed too.
Everything else looks good for me, good job.
On 11/08/17 06:56, Viktor Semykin wrote:
> Hello xfce team.
> I have implemented nice timezone selection widget and added it to
> libxfce4ui and then modified clock plugin in xfce4-panel to use this
> widget. What is the way to get this code accepted/rejected into
> mainline xfce code?
> This is my libxfce4ui: , this is my xfce4-panel:  and this is
> YouTube video demonstrating the selector in action: 
>  https://bitbucket.org/thesame/libxfce4ui/branch/timezone
>  https://bitbucket.org/thesame/xfce4-panel/branch/timezone
>  https://youtu.be/elHEXriC8oo
More information about the Xfce4-dev