[wip] gigolo port to gtk3

[Enrico Tröger]

On 20/06/16 21:09, Landry Breuil wrote:
> On Sun, Jun 19, 2016 at 11:56 PM, Enrico Tröger <enrico at xfce.org> wrote:
>> Hi,
>>
>>> this evening i wanted to do more porting to gtk3.. and gigolo was
>>> waiting for me. I have to admit i never looked at the code before, but
>>> it's very well structured, and it's been quite easy to get it to a state
>>> where it builds and basically runs.
>>>
>>> There's still of course lots of deprecated symbols still in use, and i
>>> need to properly fix/do the GtkApplication unique dance, and waaayyy
>>> more testing, but so that the work isnt lost, i've pushed it to a user
>>> repo at http://git.xfce.org/users/landry/gigolo/
>>>
>>> Enrico, if you feel like giving it a shot..
>>> I've updated https://wiki.xfce.org/releng/4.14/roadmap#applications.
>>
>> Woohoo, looks great.
>> I noticed only one thing: the main box which contains the icon view and
>> tree view is too small, IIRC there was some change in GTK3 regarding
>> default packing behaviour in GtkBox'es.
>>
>> Attached is a trivial patch which sets the expand flag to the container
>> so it will look properly again.
>> Though I'm not sure if this is the best approach, I'm not really
>> familiar with GTK3.
> 
> Not really familiar either, but i had solved it this way:
> http://git.xfce.org/users/landry/gigolo/commit/?id=dd0e669bfd2df91ccad081f4a3c4fdf1a6b70a38
> For me only the treeview was 'shrunk', not the icon view.

Nice.
But if you start with treeview and then switch to icon view using the
View menu, the icon view is still shrunk.
I guess it just needs a gtk_widget_set_hexpand() call for the icon view
as well.


> Since then i converted some stuff from deprecated to non-deprecated APIs,
> and still on the line there's:
> 
> - GtkImageMenuItem -> ?

Is it used at all? I couldn't find a reference.

> - GtkAction -> GAction ?

Not sure.

> - GtkStatusIcon -> ?

It seems GTK people suggest to use notifications only. But this is
hardly a replacement, IMO.
Does anyone know if there is something similar in Gnome like good old
status icons?

> - GtkUIManager -> no replacement ?

Maybe GtkBuilder + Glade or just write the relevant code by hand, IIRC
it's only used for creating the menu items and their related actions.

Regards,
Enrico

-- 
Get my GPG key from http://www.uvena.de/pub.asc

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: OpenPGP digital signature
URL: <https://mail.xfce.org/pipermail/xfce4-dev/attachments/20160620/05b5f13f/attachment.sig>