ANNOUNCE: xfce4-power-manager 1.3.0 released

Guido Berhoerster gber at opensuse.org
Fri Jun 6 16:35:41 CEST 2014


* Simon Steinbeiß <simon at xfce.org> [2014-06-06 00:24]:
> On Thu, 5 Jun 2014 11:42:52 +0200
> Guido Berhoerster <gber at opensuse.org> wrote:
> Looks fine, as I said:
> http://www.zimagez.com/zimage/screenshot-2014-06-06-001150.php
> We can cut down those strings a bit though to "hr" and "min".

I don't think that solves the issue since it really depends on the
theme and font size. Since the hscale does not have a native width
its size seems depends on the combobox above it, so it might be
a good idea to set a width request for it. The problem is only that
the width required to acommodate the value label depends on
the maximum possible width of localized textual representations
of every value of the timespan. Unfortunately, I don't have a
good idea how to solve this properly.

> > > > - why does the label on the "Display" tab say "Disable power saving"?
> > > >   if it is supposed to mean "Display Power Saving" it can probably
> > > >   be removed altogether
> > > 
> > > Good catch, that must be a left-over of the restructuring
> > > that settings dialog a few times. :)
> 
> You might've noticed I renamed it for now to be more in line with
> the system tab, which has an analogous label.

OK, thanks.

> > Equal alignments and as few alignment lines as possible make it
> > much easier to scan through a table, see
> > https://developer.gnome.org/hig-book/2.32/hig-book.html#window-layout-spacing
> > and
> > https://developer.gnome.org/hig-book/2.32/hig-book.html#layout-callouts-figure,
> > https://developer.gnome.org/hig-book/2.32/hig-book.html#preference-windows
> 
> Generally we do use equal alignments and I tried to follow that
> HIG. The labels in the tables won't expand, only the ones with
> the scales. The padding in between is 6px and around everything
> 12px, as mentioned in the HIG.
> Anything in particular you'd wanna see changed here?
> Maybe attach a mockup or simply edit the glade file so that it's
> clear.

I'd either left align the widget inside the table cell or expand
and fill, see the attachments.

> 
> > Hmm, at least with the Adwaita theme it is hard to read and implies
> > something is deactivated when it is not. Though I'm not sure how
> > such a table should look like and I'm not aware of any precedent...
> 
> We could also show icons instead, but that'd also look fairly
> non-standard. If people feel it's misleading, we can change it I
> guess (as soon as we know what to).
> 
> > I'm just wondering why you wouldn't want this to always be enabled
> > (when NM is available).
> 
> Talk to the person who submitted this bugreport:
> https://bugzilla.xfce.org/show_bug.cgi?id=10702

Bypassing NM like that via systemd seems just plain wrong, NM has a
script dispatcher for this purpose and it works for any case where
the network goes down, not just sleep/hibernate. In fact distros
actually supply such scripts to unmount SMB and NFS shares when the
network goes down.
But anyway, the use case seems to be such a hack that to me it
doesn't seem to too much to ask for that people configure this
directly in xfconf rather than exposing it in the UI.

> 
> > Well in this case upower cannot tell whether it is on battery or AC
> > and there are no brightness controlling devices, yet I can set the
> > inactivity time and brightness level for battery but not AC which
> > seems weird.
> 
> Yeah, the settings dialog has to become more dynamic and
> responsive in that respect (and others). I'm mostly happy if
> people are ok with the way I re-organized things (which was quite
> time-consuming), I hope it's more accessible this way. Next step
> will be exactly what you're asking for.

OK, cool.

> > It's not so much about laptop vs desktop but the presence of
> > devices which are exposed by upower, i.e. you might want to
> > couple the visibility/sensitivity of widgets based on upower
> > properties, mostly the presence of a bightness controlling device
> > and one or more batteries (of course with the new design this is
> > a bit more complicated than before where you could hide the
> > tabs).
> 
> Yeah, it's still not that complicated though, just a few lines
> more. Given with how many lines we could theoretically save with
> cleaning up that file a bit, I guess it'll be ok.
> 
> > xfpm maintenance is sorely needed, so thanks taking care of it.
> 
> Trying our best :)

-- 
Guido Berhoerster
-------------- next part --------------
A non-text attachment was scrubbed...
Name: xfpm-settings-1.ui
Type: application/x-designer
Size: 79576 bytes
Desc: not available
URL: <https://mail.xfce.org/pipermail/xfce4-dev/attachments/20140606/3c8dc3c3/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: xfpm-settings-2.ui
Type: application/x-designer
Size: 78052 bytes
Desc: not available
URL: <https://mail.xfce.org/pipermail/xfce4-dev/attachments/20140606/3c8dc3c3/attachment-0003.bin>


More information about the Xfce4-dev mailing list