xfce4-power-manager: Keyboard brightness patch for review

[Nir Gilboa]

Hi Carl,

Running the patched xfce-power-manager --no-daemon produces the following
output on my Dell E5420:
(xfce4-power-manager:2584): xfce4-power-manager-WARNING **: Failed to get
keyboard max brightness level : Method "GetMaxBrightness" with signature ""
on interface "org.freedesktop.UPower.KbdBacklight" doesn't exist

However Fn+[Right Arrow] still circles through 5 levels of brightness - as
I understand this is supported through the BIOS.

Any ideas ?
Thanks and BR
Nir Gilboa
gilboa.nir at gmail.com



On Tue, Jun 10, 2014 at 6:10 AM, Nir Gilboa <gilboa.nir at gmail.com> wrote:

> Yep :-) Thank you!
> On Jun 10, 2014 1:56 AM, "Carl Simonson" <simonsonc at gmail.com> wrote:
>
>> Nir,
>>
>> No, you don't need to compile the complete code base. Compiling
>> xfce4-power-manager is sufficient.
>>
>> What I've been doing as I was developing is running the standard
>> "./configure" and "make". I then run the program from the src directory:
>>
>> src/xfce4-power-manager --no-daemon
>>
>> I run it with "--no-daemon" so I can kill it and watch standard out if
>> necessary.
>>
>> Is that enough to get you going?
>>
>> Carl Simonson
>> simonsonc at gmail.com
>>
>>
>> On Sun, Jun 8, 2014 at 3:38 PM, Nir Gilboa <gilboa.nir at gmail.com> wrote:
>>
>>> Hi Carl,
>>>
>>> I'd like to test your patch - could you please give me some pointers on
>>> how to easily test your patch ?
>>> Do I need to follow the instructions on building the complete xfce
>>> codebase or can I build the power-manager by itself ?
>>>
>>> I'd appreciate a few pointers - I'm new to this..
>>> Thanks and BR,
>>> Nir Gilboa
>>>
>>>
>>> On Fri, Jun 6, 2014 at 5:07 AM, Carl Simonson <simonsonc at gmail.com>
>>> wrote:
>>>
>>>> I have submitted a keyboard brightness patch for review:
>>>>
>>>> https://bugzilla.xfce.org/show_bug.cgi?id=10942
>>>>
>>>> You can also see the patch at github:
>>>>
>>>>
>>>> https://github.com/simonsonc/xfce4-power-manager/commit/0c07f52289f17cc9e9d071e678be411613d0d6b8
>>>>
>>>> This patch fixes for the amount the keyboard brightness changes when
>>>> stepping up or down. It would be helpful if some people with keyboard
>>>> brightness controls could test this as well. See the commit message for
>>>> more details.
>>>>
>>>> Thanks,
>>>>
>>>> Carl Simonson
>>>> simonsonc at gmail.com
>>>>
>>>> _______________________________________________
>>>> Xfce4-dev mailing list
>>>> Xfce4-dev at xfce.org
>>>> https://mail.xfce.org/mailman/listinfo/xfce4-dev
>>>>
>>>
>>>
>>> _______________________________________________
>>> Xfce4-dev mailing list
>>> Xfce4-dev at xfce.org
>>> https://mail.xfce.org/mailman/listinfo/xfce4-dev
>>>
>>
>>
>> _______________________________________________
>> Xfce4-dev mailing list
>> Xfce4-dev at xfce.org
>> https://mail.xfce.org/mailman/listinfo/xfce4-dev
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.xfce.org/pipermail/xfce4-dev/attachments/20140701/0828e842/attachment.html>