[PATCH] Added support for matching IPv6 addresses, fixed URL parsing, and adding some characters for email address parsing.

[Natanael Copa]

On Tue, 23 Jul 2013 09:10:07 -0600
Jeff Shipley <jshipley at fastmail.fm> wrote:

> On Tue, Jul 23, 2013, at 01:24 AM, Natanael Copa wrote:
> > On Mon, 22 Jul 2013 22:39:00 -0600
> > Jeff Shipley <jshipley at fastmail.fm> wrote:
> > 
> > > From: Jeff Shipley <jshipley at fastmail.fm>
> > > 
> > > ---
> > >  terminal/terminal-widget.c |   12 +++++++-----
> > >  1 file changed, 7 insertions(+), 5 deletions(-)
> > 
> > Thank you very much for working on this. I think this is an improvement.
> > 
> > I wanted to test the patch but it appears as your mailer mangle the
> > patch so I could not apply it. (your mailer autowraps long lines). If
> > you want save developers' time you could use git send-email in future,
> > or in worst case, attach the patch.
> > 
> > I did manually apply it and tested it. It looks good and I hope the
> > maintainer applies it. (I'll resend the patch so it can be git am'ed)
> > 
> > Thank you very much!
> > 
> > -nc
> 
> I did actually send it with git send-email, but the mailing list
> rejected it (the smtp email address didn't match my subscribed email). I
> ended up copy/pasting the message, which is probably what broke the
> patch.

maybe 'git send-email --envelope-sender <subscribed-email> ...' would have worked.

> Thanks for fixing it up for me and attaching it in bugzilla.

Sorry about the bad manual edit. I should have seen it. Thanks for the cooperation. :)

> 
> btw, I was following the instructions from
> https://wiki.xfce.org/dev/howto/contribute. Perhaps that page should be
> updated?
>