xfce4-mixer patchset

[Landry Breuil]

Le 24 sept. 2012 13:13, "Guido Berhoerster" <gber at opensuse.org> a écrit :
>
> * Natanael Copa <ncopa at alpinelinux.org> [2012-09-24 11:23]:
> > On Sun, 23 Sep 2012 19:42:19 +0200
> > Harald Judt <h.judt at gmx.at> wrote:
> >
> > > Hi,
> > >
> > > Am 22.09.2012 19:29, schrieb Natanael Copa:
> > > > On Fri, 21 Sep 2012 23:17:16 +0200
> > > > Landry Breuil <landry.breuil at gmail.com> wrote:
> > > >
> > > >> I've tried building it, but failed since it inconditionally
> > > >> depends on a new thing (keybinder) not packaged yet on OpenBSD.
> > ...
> > > > One way to do it without the keybinder dependency would be to add
> > > > commands line options which you could bind keys to:
> > > >
> > > >   xfce4-mixer --volume-up
> > > >   xfce4-mixer --volume-down
> > >
> > > Implementing these command line switches would be a total waste of
> > > time. There are already a lot of command-line tools (e.g. amixer)
> > > which can do such a job perfectly,
> >
> > So if we want provide multimedia keys that works out-of-the-box on all
> > platforms, without adding keybinder dependency, what options do we have
> > really? I suppose the mentioned amixer is not available on
> > OpenBSD or any non-Linux.
> >
> > Maybe have a configure option to libxfce4ui?
>
> Distributions can just supply a preconfigured
> xfce4-keyboard-shortcuts.xml, no need to handle this upstream.
> Once OpenBSD updates their keybinder port in order they could
> also have these keyboard shortcuts handled by xfce4-mixer if they
> desire.

What i "dont like" here is that you're adding new dependencies for little
benefit, which could be already implemented within xfce, that already has
code to handle kbd shortcuts. I wouldnt mind for another random app, but
those days the mixer is generally part of xfce base installation (even if
not in core), so i'd be reluctant to add such a dep without considering
other options.

Landry
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.xfce.org/pipermail/xfce4-dev/attachments/20120924/bda9a47f/attachment.html>