Fw: [Xfce4-commits] <xfdesktop:master> Handle volume changes in a timeout (bug #7025).

Jannis Pohlmann jannis at xfce.org
Tue Jan 25 02:30:56 CET 2011


Hey folks,

please give the following commit to xfdesktop some testing. Take a look
at http://bugzilla.xfce.org/show_bug.cgi?id=7025 to see how the issue
to be fixed can be reproduced. The commit should apply fine to 4.8.0,
so even users of the stable release can test it. 

As you can imagine from the commit message, the fix is quite a dirty
workaround. Please let me know if it works for you anyway.

Thanks,
Jannis


commit 7c5dcc4fb85776174e9238c15991a7948a95529d
Author: Jannis Pohlmann <jannis at xfce.org>
Date:   Tue Jan 25 02:21:40 2011 +0100

    Handle volume changes in a timeout (bug #7025).
    
    When the "volume-changed" signal of GVolumeMonitor or the "changed"
    signal of GVolume are emitted after a volume has been mounted, then
    for some reason the affected GVolume still has no valid GMount.
    Same happens when unmounting: the GVolume still has a valid GMount.
    
    This commit works around this by checking for a change from valid to
    invalid GMount or from invalid to valid GMount in a timeout that is
    called at most 5 times until it gives up. When a change is
    detected, the corresponding XfdesktopVolumeIcon is updated.
    
    I hope this is a suitable workaround for most machines/drives. The
    underlying issue seems to be in GIO or GVfs. It might be worth
    finding the root cause.




More information about the Xfce4-dev mailing list