About xfdesktop with GIO

David Mohr squisher at xfce.org
Wed Feb 17 17:36:00 CET 2010


On Wed, Feb 17, 2010 at 1:28 AM, Jannis Pohlmann <jannis at xfce.org> wrote:
> Hey Daniel,
>
> first of all: thanks for starting to port xfdesktop to GIO.  I noticed
> a few things in your first commits that I'd like to comment on though.
>
> You introduced checks for GUDev for volume monitoring but we don't need
> this. Please use GVolumeMonitor and GVolume/GMount/GDrive for volume
> monitoring and mounting devices.
>
> It makes little sense two re-implement file operations with
> ExoJob/ExoSimpleJob inside xfdesktop. I'd prefer if we used
> Thunar's D-Bus API here. If the API is missing one of the methods (e.g.
> delete), we can extend it. This makes sense because we want file
> operations to be presented to the user in a consistent way and this way
> we can also benefit from the shared progress dialog feature of Thunar.

Please correct me if I'm wrong, but doesn't that introduce a
dependency on Thunar? I don't think that was the case before. What
would happen if someone uses xfdesktop but Thunar is not running /
installed?

~David



More information about the Xfce4-dev mailing list