[Xfce4-commits] <xfce4-dev-tools:master> Fix XDT_FEATURE_LINKER_OPTS and XDT_FEATURE_VISIBILITY.
Brian J. Tarricone
brian at tarricone.org
Sat Sep 19 22:49:48 CEST 2009
-----BEGIN PGP SIGNED MESSAGE-----
Ok, now that I'm not half asleep, looking at this again.
On 09/19/2009 08:36 AM, Jannis Pohlmann wrote:
> AC_ARG_ENABLE executes the code its last parameter if the --enable flag
> is not provided, not if the --disable flag is not provided.
No, that's incorrect. It's:
AC_ARG_ENABLE(feature, help-string, action-if-given, action-if-not-given)
It has nothing to do with whether you pass the enable or disable
variant. "action-if-given" is run if you pass *either* --disable-foo or
- --enable-foo. "action-if-not-given" is run if you don't pass anything.
> That's why
> we need to set the value to "no", not to "yes".
Well, it depends. You set the value in action-if-not-given to whatever
you want the default to be. So your patch isn't right in that respect
since I intended 'yes' to be the default for the visibility and linker
Now, there's the action-if-given block, which is blank. That's ok in
this case because the shell variable matches the "shell safe" version of
the 'feature' argument ("linker-opts" -> "enable_linker_opts"), which
autoconf sets automatically. It's a bit of behind-the-scenes autoconf
voodoo that makes things confusing, so I'll probably (redundantly) put
code there to set it explicitly.
> Also don't show the --disable-debug option (with weird indentation)
> because the help message already explains that there are --disable
> variants for all --enable options.
Eh, I kinda liked that there. Gonna put it back if I can figure out how
to fix the indent.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.11 (GNU/Linux)
-----END PGP SIGNATURE-----
More information about the Xfce4-dev