adding _NET_WM_FULLSCREEN_MONITORS hint to xfwm4

[Jason 'vanRijn' Kasper]

On Sat, Jan 24, 2009 at 6:51 PM, Olivier Fourdan <fourdan at gmail.com> wrote:

> Hi,
>
> On Fri, Jan 23, 2009 at 11:29 PM, Jason 'vanRijn' Kasper
> <vr at movingparts.net> wrote:
> > On Fri, Jan 23, 2009 at 6:26 PM, Olivier Fourdan <fourdan at gmail.com>
> wrote:
> >> Yeah, I re-read the specs and it really doesn't sound too complicated
> >> at all... I should be able to cook something before rc1.
> >>
> >> Thanks for the heads up!
> >
> > Thank you Olivier!!! =:)
>
> Ok, it's in svn, rev. 29311. (untested).
>


WOW, awesome! I forgot to mention, there is a simple test program here:
http://bugzilla.gnome.org/show_bug.cgi?id=414476 that was posted as part of
the metacity patch. It's pretty simple, but it does verify that the WM can
handle the request and spread the fullscreen window over the first and
second heads, as requested.

I found a bit confusing that the list of monitors is top, bottom, left
> right whereas other such as "struts" use left, right, top, bottom
> instead.
>

Yeah, I know what you mean. =:/


> Also in the implementation for metacity, I fail to understand why the
> property NET_WM_FULLSCREEN_MONITORS is set only when the window is
> fullscreen, it should be set any time the client message is received
> and not only when the window is fullscreen, that goes a bit against
> what is done for other properties. My implementation does not follow
> this and do set the property when the client message is received, the
> window being fullscreen or not.
>

I believe your implementation  is correct and this is how I did kwin's
implementation (and how compiz's implementation was done too, iirc).

Thank you for doing this Olivier! I'll test this out on Monday, for sure.

Thanks again!!! =:)


-- 
-[ Jason 'vanRijn' Kasper    //  http://movingparts.net ]-
-[ KDE PIM Developer         //  http://www.kde.org  ]-
-[ bash fun -> :(){ :|:&};:  //  Numbers 6:22-26 ]-
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.xfce.org/pipermail/xfce4-dev/attachments/20090124/fc7ad9f1/attachment.html>