[Xfce4-commits] r29572 - in xfwm4/trunk: . settings-dialogs

[Olivier Fourdan]

On Tue, Feb 24, 2009 at 7:28 PM, Nick Schermer <nickschermer at gmail.com> wrote:
> 2009/2/24 Olivier Fourdan <olivier at xfce.org>:
>> Author: olivier
>> Date: 2009-02-24 18:53:37 +0000 (Tue, 24 Feb 2009)
>> New Revision: 29572
>>
>> Modified:
>>   xfwm4/trunk/ChangeLog
>>   xfwm4/trunk/settings-dialogs/tweaks-settings.c
>>   xfwm4/trunk/settings-dialogs/xfwm4-settings.c
>> Log:
>>        * settings-dialogs/xfwm4-settings.c,
>>          settings-dialogs/tweaks-settings.c: Do not run setting dialogs if
>>          current window manager is not xfwm4 (Bug #4989).
>
> I think the error will be confusing since it won't show up in a
> dialog. IMHO we make string freeze exception and make this
> translatable showing in a message dialog, or drop it.
>
> We could also add a hook in the settings manager, not showing the
> xfwm4 settings if xfwm4 is not running, but then it'll still be
> accessible from the menu. Probably not a good idea... Maybe implement
> a TryExec thing in the future?

Remember, this is to fix a crash, see bug #4989 - But I am not
personally interested much in fixing the crash, not even investigating
too much (I don't feel too concerned if xfce4-settings is started from
gnome and segfaults - But it should not segfault, it's ugly)

Beside this is to fix a regression that was introduced in 4.6, and
moreover xfce4-panel swettings dialog behaves jut the same, it spews a
error message to the console and fails to start if the panel is not
running. So at least we are consistent betweem modules ^_~

I am not really fond of reverting this, but I agree this is not a the
best of all fixes, but at least it fixes a segfault... But it is not
critical, so I am ok if this is not part of 4.6 (but this is really a
trivial fix, the code was there since 4.2 or so so I consider it well
tested)

Cheers,
Olviier.