[Xfce4-commits] r29572 - in xfwm4/trunk: . settings-dialogs

[Brian J. Tarricone]

Nick Schermer wrote:
> 2009/2/24 Olivier Fourdan <olivier at xfce.org>:
>> Author: olivier
>> Date: 2009-02-24 18:53:37 +0000 (Tue, 24 Feb 2009)
>> New Revision: 29572
>>
>> Modified:
>>   xfwm4/trunk/ChangeLog
>>   xfwm4/trunk/settings-dialogs/tweaks-settings.c
>>   xfwm4/trunk/settings-dialogs/xfwm4-settings.c
>> Log:
>>        * settings-dialogs/xfwm4-settings.c,
>>          settings-dialogs/tweaks-settings.c: Do not run setting dialogs if
>>          current window manager is not xfwm4 (Bug #4989).
> 
> I think the error will be confusing since it won't show up in a
> dialog. IMHO we make string freeze exception and make this
> translatable showing in a message dialog, or drop it.

I'd agree that a console message sucks... but breaking string freeze now 
is really not nice to the i18n team at all.

> We could also add a hook in the settings manager, not showing the
> xfwm4 settings if xfwm4 is not running, but then it'll still be
> accessible from the menu. Probably not a good idea...

Terrible idea.

> Maybe implement a TryExec thing in the future?

How will TryExec help?

	-b