4.6.0

[Stephan Arts]

On Wed, Feb 18, 2009 at 6:34 PM, Olivier Fourdan <fourdan at gmail.com> wrote:
> On Wed, Feb 18, 2009 at 1:56 PM, Nick Schermer <nickschermer at gmail.com> wrote:
>> 2009/2/18 Stephan Arts <stephan at xfce.org>:
>>> On Wed, Feb 18, 2009 at 2:04 PM, Jannis Pohlmann <jannis at xfce.org> wrote:
>>>> Am Wed, 18 Feb 2009 09:07:09 +0100
>>>> schrieb Yves-Alexis Perez <corsac at debian.org>:
>>>>
>>>>> On mar, 2009-02-17 at 21:00 +0000, Olivier Fourdan wrote:
>>>>> > On Tue, Feb 17, 2009 at 2:19 PM, Jannis Pohlmann <jannis at xfce.org>
>>>>> > wrote:
>>>>> > > Here's the patch again, this time without debug output.
>>>>> >
>>>>> > Okay, then do all parties agree on committing this then?
>>>>> >
>>>>> > I do not believe that computing the DPI per monitor is a practical
>>>>> > approach, I am not aware of a way to retrieve the actual monitor
>>>>> > size (only the screen size is available, maybe with RandR?)
>>>>>
>>>>> Sorry for not replying sooner. I've tried this, and disabling the
>>>>> "forced DPI" (which is at 125 here) with the patched xfce4-settings
>>>>> works pretty fine, the fonts were just ok. But the value in the (now
>>>>> greyed) box was set to 48, which seems weird.
>>>>
>>>> That should be fixed with my patch because it allows values from -1 on.
>>>> So when you disable custom DPI you'll get -1 in the spin button, when
>>>> you enable custom DPI again, it'll still be -1 and then you have to set
>>>> it on your own.
>>>
>>> That is just as bad, since when you use the spin-button then, it will
>>> set the DPI to '0', '1', etc... Not quite the values you'd like ;-)
>>
>> IMHO i think we should show the DPI we send to x in the insensitive
>> spin button (that's what my reverted patch did). Storing the user dpi
>> is not really needed IMHO as long as we don't show crap like -1 or 0.
>
> I agree, we either remember the previous value (ie add another boolean
> setting instead of using -1 for disabled) or we just apply my original
> patch.

Agreed, lets just commit your patch and be done with it.

I have spoken with sofar to resurrect www-test.xfce.org for testing
http://svn.xfce.org/svn/www/www.xfce.org/branches/www.xfce.org-4.6, a
branch where we can place all our xfce 4.6.0 related website-changes.

Regards,
Stephan