"Eject" and "Unmount"

[Brian J. Tarricone]

On Thu, 12 Feb 2009 07:47:40 +0100 Yves-Alexis Perez wrote:

> On jeu, 2009-02-12 at 14:03 +0800, Shou-Lien Chen wrote:
> > hello all:
> > According to
> > http://www.xfce.org/documentation/api/thunar-vfs/ThunarVfsVolume.html#thunar-vfs-volume-is-ejectable
> > The thunar_vfs_volume_is_ejectable () should return TRUE only if a
> > medium is present and the volume is removable Is this mean it
> > reference the hal key: storage.removable = true  ? I found my usb
> > disk and sd card is treat as "reject" if I want remove them, but
> > there is a storage.requires_eject = false key  found if I monitor
> > my usb disk by lshal command
> > 
> > Thus, which hal key is referenced by the thunar-vfs lib to judge if
> > a volume need to be eject or unmount?
> 
> http://bugzilla.xfce.org/show_bug.cgi?id=3978

Jannis, can you explain this change a bit better? Unless I'm
misunderstanding, that fix is incorrect.

thunar_vfs_volume_is_ejectable() should NOT correspond to
storage.requires_eject.  Just because a volume doesn't *require* eject,
it doesn't mean that it's not ejectable.

As previously discussed, we should *not* have "Unmount" in Thunar's (or
xfdesktop's) UI anywhere.  Any place where we do would be considered a
usability bug.

Ejecting normal USB media is entirely safe and probably a good idea
(after unmounting), even if storage.requires_eject is false.

	-brian