EggSMClient just isn't working out

[Brian J. Tarricone]

Hey guys,

So I found a couple new issues with EggSMClient:

2.  Can't change SmRestartStyleHint after connected to the SM (required
for "(xfdesktop|xfwm4|xfce4-panel|xfce4-settings-helper) --quit" to work).

3.  egg_sm_client_is_resumed() doesn't do what we want -- we want to
know if we're connected to the session manager at all, whereas
_is_resumed() tells us if we got resumed from a previous session (it'll
return FALSE if we connected to the SM for the first time).  This breaks
xfce4-settings-helper's autostart munging code.

(#1 of course was the lack of SmRestartImmediately support that I fixed
a few weeks ago.)

Both of these issues are fixable, but I'm starting to wonder what other
issues I might find... plus I have limited time and I'd rather devote it
to things more worthwhile than improving a temporary library that we
intend to throw away anyway.

Especially when we already have something that works:

I'd suggest we ditch EggSMClient and instead import SessionClient from
libxfcegui4, probably still into libxfce4smclient-private, since I
certainly wouldn't consider it something we want to keep as public
supported API.

SessionClient isn't perfect, but it works well enough for what we do,
and we know its faults.  There's also a patch in bugzilla[1] that we
should apply that can improve it further.  Honestly, I'd be happy to
refactor the existing code and turn it into a nice GObject with signals
and a non-sucky API for 4.10, but it's ok as-is for 4.8 in a "private
lib" capacity.

Thoughts?

	-brian

[1] http://bugzilla.xfce.org/show_bug.cgi?id=5377