Netk deprecation notice [WAS Re: [proposal] Modify the panel-plugin interface, add 'powersave-mode'.]

[Stephan Arts]

On 7/14/07, Brian J. Tarricone <bjt23 at cornell.edu> wrote:
> On Sat, 14 Jul 2007 13:44:53 +0200 Stephan Arts wrote:
>
> > On 7/14/07, Nick Schermer <nickschermer at gmail.com> wrote:
> > > I think if you do a replace s/netk/wnck/g on the code, your done for
> > > 99%... Most of the function (public ones) have the same name, which
> > > is good of course :-).
> > >
> > > On a side note, if we remove netk out of libxfcegui4, isn't it
> > > better to start moving usefull pieces of code to libxfce4ui, the
> > > cleanup mentioned some time ago by Benny?
> > >
> > > Nick
> > >
> > > @ Stephan, Diego: sure go ahead, as long as it compiles and works.
> >
> > WnckPager does not support workspace-scrolling, something NetkPager
> > does.
> >
> > What should we do with that? Remove the feature?
>
> Subclass WnckPager in the panel plugin itself and add the scrolling
> feature.

... could have thought about that myself. I implemented it that way though :-).

Here i have a preliminary patch, going to fix some small issues with
it (mainly coding-style stuff), please let me know if you have some
sugestions or comments.

This is what I have done so far:

* subclassed WnckPager with XfcePager and added the scrolling feature
* replaced netk with wnck inside the pager, iconbox, tasklist,
windowlist and showdesktop plugins.
* add HAVE_WNCK_TASKLIST_SET_SHOW_LABEL ifdefs to the tasklist.
* add wnck_tasklist_set_show_label to configure.in.in function check
(i am not sure if it will work, perhaps we need our own macro for
that)
* The pager can now be configured to display workspace-names instead
of contents. (Bug #3392)

One more thing, could we rename the 'pager' to 'workspace switcher'?
I am not sure about other languages, but pager is kind of hard (if at
all) to translate (in dutch anyway). 'Workspace switcher' might be an
easier name which kind of covers the purpose.

Stephan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pager-netk-cleanup-preliminary.patch
Type: text/x-diff
Size: 54449 bytes
Desc: not available
URL: <http://mail.xfce.org/pipermail/xfce4-dev/attachments/20070718/a3967749/attachment.patch>