[Xfce4-commits] r24827 - libxfcegui4/branches/xfce_4_4/libxfcegui4

[Stephan Arts]

On 2/6/07, Danny Milosavljevic <danny_milo at yahoo.com> wrote:
> Hi,
>
> On Sun, 04 Feb 2007 22:51:07 +0100, Nick Schermer wrote:
> > I don't see the use of all these commits,
>
> It seems I opened a can of worms by adding getters where they were missing.
>
> I.e. one can set icon geometry, yet one can't read it. One can set Tasklist properties, but one can't read them.
>
> Trivial, really.
>
> > but to prevent this discussion, you could have asked on the ml (or bugzilla) _before_ committing in both trunk and xfce_4_4,
>
> That would have lead to the same discussion, nothing would have changed.
>
> If you instead said that you would have preferred it if I asked on the (xfce4-dev?) Mailing List before committing to xfce_4_4, I would take that into account.
>
> > that's not a bad thing if you work in a group?
>
> ?
> Did someone say it was a bad thing?
> I must be too tired right now...
>
> > Esp. when you commit in a module you're not working on on your own.
>
> I'm currently adjusting my judging criterias for "trivial bugfix" in Xfce. Or for "bugfix", no, for "bug", it seems.

Please don't take it so hard, but changing an API in a stable branch
is widely regarded as a 'bad' thing. And concidering the functions
added are not used *at all*, and that library will probably be
depricated for the next release, i do not see why aesthetics can be
the cause of breaking an API.

Regards,

Stephan