[Xfce4-commits] r24827 - libxfcegui4/branches/xfce_4_4/libxfcegui4

Danny Milosavljevic danny_milo at yahoo.com
Tue Feb 6 02:03:36 CET 2007


On Sun, 04 Feb 2007 22:51:07 +0100, Nick Schermer wrote:
> I don't see the use of all these commits, 

It seems I opened a can of worms by adding getters where they were missing.

I.e. one can set icon geometry, yet one can't read it. One can set Tasklist properties, but one can't read them.

Trivial, really.

> but to prevent this discussion, you could have asked on the ml (or bugzilla) _before_ committing in both trunk and xfce_4_4, 

That would have lead to the same discussion, nothing would have changed.

If you instead said that you would have preferred it if I asked on the (xfce4-dev?) Mailing List before committing to xfce_4_4, I would take that into account.

> that's not a bad thing if you work in a group? 

Did someone say it was a bad thing?
I must be too tired right now...

> Esp. when you commit in a module you're not working on on your own.

I'm currently adjusting my judging criterias for "trivial bugfix" in Xfce. Or for "bugfix", no, for "bug", it seems.


More information about the Xfce4-dev mailing list