libxfce4ui

[Brian J. Tarricone]

Christian Dywan wrote:
> Am Mon, 17 Dec 2007 13:32:47 -0800
> schrieb "Brian J. Tarricone" <bjt23 at cornell.edu>:
> 
> Hi Brian,
> 
>> I feel like XfceFrame is exactly the sort of cruft we want to get rid 
>> of.  The xfce_create_framebox() helper was created (recently!)
>> because XfceFramebox was broken.  Essentially:
>>
>> GtkWidget *vbox, *align, *lbl;
>> vbox = gtk_vbox_new(FALSE, 6);
>> lbl = gtk_label_new_with_markup("<span weight='bold'>Foo</span>");
>> gtk_container_add(GTK_CONTAINER(vbox), lbl);
>> align = gtk_alignment_new(0.5, 0.5, 1.0, 1.0);
>> g_object_set(align, "left-padding", 12, NULL);
>> gtk_container_add(GTK_CONTAINER(vbox), align);
>>
>> Is it really necessary to have an extra widget for that?  If 
>> xfce_create_framebox() is doing much more than that, it shouldn't be. 
>> As you said, it's easy to add stuff later if we find we need it; hard
>> to remove the pointless stuff if it's really pointless.
> 
> You are talking about usability in the context of message dialogs. I
> think Xfce has even more frames than dialogs, so they are not exactly
> unimportant. I wonder why you call this "cruft" then.
> 
> There are two possibilities to supersede the old frame code:
> 
> a) Provide a nice function or widget for a frame that respects
> usability.
> 
> b) Explain why you prefer copying redundant code and what steps to
> follow to maintain a consistent interface, maybe in the wiki.

Neither is necessary: I suggest you actually read what I wrote, and look 
up what we have currently in libxfcegui4 (which, coincidentally enough, 
I wrote).  Hint: xfce_create_framebox().

	-brian