[Xfce4-commits] r19323 - libxfcegui4/trunk/libxfcegui4

[Jasper Huijsmans]

Brian J. Tarricone schreef:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On 1/6/2006 2:52 PM, Danny Milosavljevic wrote:
>> Author: dannym
>> Date: 2006-01-06 22:52:03 +0000 (Fri, 06 Jan 2006)
>> New Revision: 19323
>>
>> Modified:
>>    libxfcegui4/trunk/libxfcegui4/xfce-exec.c
>> Log:
>> live dangerously by doing the child_watch / do not reap child
>> thing that surely will kill us with SIGCHLD one day
> 
> Danny, are you sure this is really a good idea?  Personally I'd rather
> we do something like calling setsid() so the new process gets its own
> session.  That way, if, say, I start an app from the panel, and then
> later kill the panel, the app doesn't die too.  (Actually I think the
> panel doesn't use xfce_exec() anymore, but you get my point.)
> 
> So what we should do here is provide a GSpawnChildSetupFunc to
> gdk_spawn_on_screen() that does nothing but call setsid().  I'm pretty
> sure that doing this makes it unnecessary to add the child_watch_cb.
> 

SIGCHLD is ignored by default, isn't it? Also, the panel does use 
xfce_exec for launchers. I'm also not sure g_spawn_async doesn't already 
detach child processes if you don't pass a location to store the pid.

I'm afraid I missed the commit, so I didn't see what changed.

	Jasper