[Xfce4-commits] r19323 - libxfcegui4/trunk/libxfcegui4

[Brian J. Tarricone]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 1/6/2006 2:52 PM, Danny Milosavljevic wrote:
> Author: dannym
> Date: 2006-01-06 22:52:03 +0000 (Fri, 06 Jan 2006)
> New Revision: 19323
> 
> Modified:
>    libxfcegui4/trunk/libxfcegui4/xfce-exec.c
> Log:
> live dangerously by doing the child_watch / do not reap child
> thing that surely will kill us with SIGCHLD one day

Danny, are you sure this is really a good idea?  Personally I'd rather
we do something like calling setsid() so the new process gets its own
session.  That way, if, say, I start an app from the panel, and then
later kill the panel, the app doesn't die too.  (Actually I think the
panel doesn't use xfce_exec() anymore, but you get my point.)

So what we should do here is provide a GSpawnChildSetupFunc to
gdk_spawn_on_screen() that does nothing but call setsid().  I'm pretty
sure that doing this makes it unnecessary to add the child_watch_cb.

	-brian

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (MingW32)

iD8DBQFDv4MO6XyW6VEeAnsRAtdOAKDV3Nf039QKGVDCf4M49hDF98AerwCeO6tp
820URNWYm8F7HYIVg/k4f2U=
=Mqhv
-----END PGP SIGNATURE-----