Notes on the new panel

[Brian J. Tarricone]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 9/22/2005 1:18 AM, Jasper Huijsmans wrote:
> Jannis Pohlmann schreef:
> 
>>>>>I'm currently working on an iconbox plugin. After that I think it is 
>>>>>only the clock plugin that needs to be ported. Would you like to have a 
>>>>>look at that? I think it is ok to port the current panel plugin first 
>>>>>and look at merging with the date-time plugin later.
>>>>
>>>>
>>>>Yeah, why not. I'll have a look at it later today. Should be no problem,
>>>>I think.
>>>
>>>
>>>I'm working on it at the moment and I stumbled across a problem. The old
>>>clock was resized whenever its mode was changed. It used icon_size[size]
>>>(xfce4-panel/plugins/clock.c, line 276). What's this and is there a
>>>better solution already (I noticed a comment in
>>>xfce4-panel/panel/global.h on this)?
>>
>>
>>I found a solution for this. I now set the led size by checking the size
>>and comparing it with DIGIT_*_HEIGHT (xfce_clock.c). Unfortunately,
>>DIGIT_*_HEIGHT defines are not in xfce_clock.h so I have to use their
>>values (10, 14, 20). Perhaps we should move them into the header, what
>>do you think?
>>
> 
> I think the clock widget should be taken out of libgui and be part of 
> the clock plugin. Nothing else is using it, AFAIK.

I always wondered why that was in libgui in the first place...  But
taking it out will break ABI.  Granted, there's a 99% chance that no one
in the entire world but the panel is using it, but...

	-b

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (MingW32)

iD8DBQFDMmpJ6XyW6VEeAnsRAkSpAJ9aEkiFgrxf4VA+U5gZM6Gkpi854ACfWnzH
eY2BFq7PdVUOab5AOzwZMJM=
=TqWd
-----END PGP SIGNATURE-----