xfwm4 restore on move - patch

[Olivier Fourdan]

Hi Ori

Humm... I think this is wrong :

> if (xevent->xmotion.y_root - passdata->oy > 50)
                             ^^^^^^^^^^^^^^^^^^
Seems it's there to avoid a side effect with snapping, but snapping is
configurable, so when snapping is set to its widest value, the restore
on move doesn't work.

HTH
Olivier.


On Sun, 2005-03-27 at 23:02 +0200, Olivier Fourdan wrote:
> Hi Ori,
> 
> BTW, it looks better now
> 
> Cheers,
> Olivier.
> 
> On Sun, 2005-03-27 at 22:56 +0200, Olivier Fourdan wrote:
> > Hi Ori,
> > 
> > Given the implementation of the compositor in xfwm4, there is a good
> > chance that the compositing manager will prevent you from seeing the
> > bug.
> > 
> > Start xfwm4 with --compositor=off
> > 
> > eg:
> > 
> > killall xfwm4 && xfwm4 --compositor=off &
> > 
> > 
> > HTH
> > Olivier.
> > 
> > On Sun, 2005-03-27 at 15:38 -0500, Ori Bernstein wrote:
> > > On Sun, 27 Mar 2005 19:45:54 +0200
> > > Olivier Fourdan <fourdan at xfce.org> dared to utter:
> > > 
> > > > Ori,
> > > > 
> > > > I think the patch needs a bit more work because it doesn't work very
> > > > well with the Alt+Click move of windows. 
> > > 
> > > I agree - it has some odd behavior, but not what you describe below.
> > >  
> > > > To try, maximize a window and use Alt+Click to move it instead of the
> > > > titlebar, the window quickly toggle between maximized and un-maximized
> > > > state at every mouse move...
> > > 
> > > I can't duplicate this behavior - I tried both on the previous account, where I
> > > had tweaked the settings a bit, and a completely new account using default
> > > settings, with a fresh CVS checkout of xfwm4. The closest I can get is causing
> > > the window to flash fullscreen when the border passes the top of the screen.
> > > 
> > > I'm sing X 6.8.2  dual monitor system (Nvidia Twinview, specifically) with xfwm4
> > > configured the following:
> > >       --prefix=/usr \
> > >       --sysconfdir=/etc/X11 \
> > >       --enable-static=no \
> > >       --enable-xinerama \
> > >       --enable-compositor
> > > 
> > > However, I find it's currently quite easy to get to where you're moving a window
> > > from a point outside of it with alt-click. Solution: when the maximized gets
> > > toggled, the window gets moved to the pointer in y as well as x.
> > > 
> > > Currently, though, it sometimes misses maximization when it gets snapped to the
> > > top of the screen. Solution: when the window is in toggled_maximize == true,
> > > don't try to snap to top of monitor.
> > > 
> > > Attached is a fix for the recentering and the missed remaximization. I'm not
> > > sure how to deal with the flashing to maximized when moving above the top of the
> > > screen - one possibility is just disabling the resizing when moving windows with
> > > alt-click?
> > > 
> > > _______________________________________________
> > > Xfce4-dev mailing list
> > > Xfce4-dev at xfce.org
> > > http://foo-projects.org/mailman/listinfo/xfce4-dev
> > 
> > 
> > _______________________________________________
> > Xfce4-dev mailing list
> > Xfce4-dev at xfce.org
> > http://foo-projects.org/mailman/listinfo/xfce4-dev
> > 
> 
> 
> _______________________________________________
> Xfce4-dev mailing list
> Xfce4-dev at xfce.org
> http://foo-projects.org/mailman/listinfo/xfce4-dev
>