xfce_icon_theme -> gtk_icon_theme?

[Brian J. Tarricone]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jasper Huijsmans wrote:
> Hey Brian,
> 
> I was wondering if we should try and port all xfce modules to use 
> GtkIconTheme and/or turn XfceIconTheme into a small wrapper.
> 
> The only thing I see that gtk icon theme does not support is the use of 
> icon lists. Maybe we should just give up on that and use 'xfce-' 
> namespaced icons instead or possibly icons named according to the 
> proposed icon naming spec on freedesktop.org.
> 
> What do you think? It would save quite some duplicated effort, isn't it?

This has been on my todo list for a while, but (as usual) I haven't
gotten to it.  At this point (for 4.4), the only real benefit of doing
this would be to be able to use the icon theme cache that gtk 2.6 (I
think 2.6) and higher makes use of, which will improve speed.  However,
on my system at least, the bottleneck is loading and rendering SVG
icons, not the actual lookups, so...  Anyway, I'd suggest one of these
options:

1.  Turn XfceIconTheme into a wrapper (kinda a proxy object) over
GtkIconTheme.  The good part is it means not needing to change any apps
that use XfceIconTheme.  The bad part is extra object overhead, which I
guess isn't a big deal.

2.  Stop using XfceIconTheme entirely, and instead use the
xfce_themed_icon_*() functions in libxfcegui4/icons.h, which can be
modified to use GtkIconTheme instead of XfceIconTheme (which needs to be
done anyway, as there are some apps that use these instead of
XfceIconTheme directly).

Personally I prefer #2.  We don't really need our own icon theme object
anymore, and the wrapper functions can serve to tweak search paths, add
fallback functionality as needed, etc.  We can deprecate XfceIconTheme
and only have one thing (the functions in icons.h) to worry about.

As for the icon naming spec, I have no problem adding the new icon names
to the list lookup.  That's pretty easy to do.

Overall, unless someone has some time on their hands (yeah, right), I'd
suggest leaving the icon theming stuff as-is until 4.6.  It'll take a
bit of work and testing time that could be spent elsewhere.

	-b

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)

iD8DBQFDsxUm6XyW6VEeAnsRAp+1AJ9MHw1WjIOwoKi465k0AxlQylomqwCgpLGx
byv3tC3wU08+L+BVXJDss4U=
=stae
-----END PGP SIGNATURE-----