Panel Settings Dialog (again)

[Stefan Stuhr]

The new user interface for customizing the panel is cool, better than
any of the other I have tried (I didn't tried the last one).

Jasper Huijsmans wrote:
> Jani Monoses schreef:
> ...
> > - move DnD is nice but the dragged image has the part of the context
> > menu screenshot in it at least here :) 
> 
> Hmm. Does this patch help?

It does help here.

> Index: panel.c
> ===================================================================
> --- panel.c     (revision 19067)
> +++ panel.c     (working copy)
> @@ -439,6 +439,11 @@
>       if (priv->drag_widget)
>       {
>           plugin = priv->drag_widget;
> +
> +        /* allow menu to close, in order to not mess up the snapshot of the
> +         * plugin */
> +        while (gtk_events_pending ())
> +            gtk_main_iteration ();
>       }
>       else
>       {

I also have a problem with the plugin screen shots being centred
horizontally behind the GTK2 drag cursor, and the cursor point of the
drag cursor being the top left corner of the screen shot. This fix (use
your patch first) helps (I don't know how to make real patches, sorry):
Change line 466 in panel.c from:
        gtk_drag_set_icon_pixbuf (drag_context, pb, 0, 0);
to:
        gtk_drag_set_icon_pixbuf (drag_context, pb, -1, -1);


Jannis Pohlmann wrote:
>  - When moving a panel item to the right, between two other items, it
>    is placed on the right side of the second item. I'd expect it to be
>    placed between them - probably a bug?

I experience this bug as well.

Stefan