[Xfce4-commits] r17223 - libxfcegui4/trunk/libxfcegui4

[Benedikt Meurer]

Benedikt Meurer wrote:
> Brian J. Tarricone wrote:
> 
>>Just being nitpicky, but might I suggest a conditional #ifndef #define
>>for PANGO_ELLIPSIZE_END at the top of the file, and then use a runtime
>>version check and
>>g_object_set(G_OBJECT(task->label),
>>             "ellipsize", PANGO_ELLIPSIZE_END,
>>             NULL);
>>instead?  That way if someone upgrades gtk versions, say from 2.4 to
>>2.8, they get the bugfix without needing to recompile libgui.
> 
> 
> if ((gtk_major_version == 2 && gtk_minor_version >= 6)
>     || gtk_major_version > 2)
>   {
>     g_object_set (G_OBJECT (task->label), "ellipsize", 3, NULL);
>   }

Probably a comment that says "3 is ellipsizing at the end" wouldn't hurt
as well.

Benedikt