[Xfce4-commits] r17223 - libxfcegui4/trunk/libxfcegui4

Olivier Fourdan fourdan at xfce.org
Wed Aug 31 22:31:34 CEST 2005


On Wed, 2005-08-31 at 13:20 -0700, Brian J. Tarricone wrote:
> Just being nitpicky, but might I suggest a conditional #ifndef #define
> for PANGO_ELLIPSIZE_END at the top of the file, and then use a runtime
> version check and
> g_object_set(G_OBJECT(task->label),
>              "ellipsize", PANGO_ELLIPSIZE_END,
>              NULL);
> instead?  That way if someone upgrades gtk versions, say from 2.4 to
> 2.8, they get the bugfix without needing to recompile libgui.

I'm personally not too much in favor of redefining constants (or even
functions or whatever) on behalf of the library that implements them.

Other than that, I won't oppose such a change, but for me, my change


More information about the Xfce4-dev mailing list