Rodent and png icons

[edscott wilson garcia]

El vie, 15-10-2004 a las 21:52, Brian J. Tarricone escribió:
> edscott wilson garcia wrote:
> 
> >El jue, 14-10-2004 a las 22:06, Brian J. Tarricone escribió: 
> >  
> >
> >>edscott wilson garcia wrote:
> >>
> >>    
> >>
> >>>El jue, 14-10-2004 a las 12:04, Brian J. Tarricone escribió:
> >>> 
> >>>
> >>>      
> >>>
> >>>>the right way to use this is to have the ability to tell XfceIconTheme that
> >>>>you don't want to use SVG icons.  this is actually something that
> >>>>GtkIconTheme lets you do, but i left out for simplicity reasons.  it should
> >>>>be pretty easy to add to the API:
> >>>>void xfce_icon_theme_set_use_svg(XfceIconTheme *icon_theme, gboolean use_svg);
> >>>>gboolean xfce_icon_theme_get_use_svg(XfceIconTheme *icon_theme);
> >>>>
> >>>>i take a look at this after work today.
> >>>>   
> >>>>
> >>>>        
> >>>>
> >>>Cool. That would be great.
> >>>:-)
> >>>
> >>>      
> >>>
> >>done.  let me know if it's broken... or fix it yourself ^_~.
> >>    
> >>
> >
> >I tweaked it just a bit, so that svg icons can be used as a backup if
> >png icon is not available when:
> >xfce_icon_theme_set_use_svg(icon_theme,FALSE);
> >since the idea is to speed up rendering of large icon sets, not limit
> >the rendering ability.
> >
> >I hope this is OK with you. If not, it can be reverted and I can get the
> >same result by installing the Rodent svg icons into a separate directory
> >from the png icons (although I'd rather not).
> >  
> >
> hmm, i'm not sure i like that all that much.  that confuses the API a 
> bit, as it doesn't _really_ do what it says it does.  either you want 
> SVG or you don't; i don't think there should be an in-between.

Yes, the tweak confuses the API, I wasn't too happy either. I'll revert
the proposed tweak... Reverted.

There is a much better way, not a tweak but a fix:  if the requested
icon size matches the size of a png icon, the png icon should be
unconditionally preferred. There is no reason to scale an image that is
*already* to scale, right? 


regards,

Edscott
 

> 
>     -brian
> _______________________________________________
> Xfce4-dev mailing list
> Xfce4-dev at xfce.org
> http://lunar-linux.org/mailman/listinfo/xfce4-dev
>